Add OpenWeatherMap as third weather provider #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fliP-13
changed the title
|
Hey, looks good! I'm preoccupied with some schoolwork for the next few days, but I should have a chance over the weekend to review & publish it. |
|
Published in v1.19.0 Thanks for the contribution :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the outage of the sunset / sunrise API a few days ago, I started to implement OpenWeatherMap as additional weather provider because it can deliver sun events and weather forecast with one single API call.
Even though the original sunset / sunrise API now works again I decided to finish my implementation anyway because an additional weather provider is a nice thing to have.