Groups codes by pairs or threes depending on character count

[beaucollins]

Purely an opinion but I find it easier to read two groups of three digits vs three groups of two digits.

And for 8 digit length codes I would say two groups of four digits would be better than four groups of two digits.

This change groups any code divisible by three into groups of three, divisible by two in pairs, otherwise no groupings.

[mide]

That's a clever and elegant solution. 👍

[ghost]

I much prefer this over the always-by-twos approach that currently exists.

[jansenfuller]

Is there a particular reason why this has been shelved?

[beaucollins]

@jansenfuller I think it just needs to be brought to the attention of @mattrubin

[codecov]

Codecov Report

Merging #216 into develop will increase coverage by 0.05%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop     #216      +/-   ##
===========================================
+ Coverage    40.21%   40.26%   +0.05%     
===========================================
  Files           36       36              
  Lines         2268     2270       +2     
===========================================
+ Hits           912      914       +2     
  Misses        1356     1356

Impacted Files	Coverage Δ
Authenticator/Source/TokenRowModel.swift	96.15% <100%> (+0.32%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fc8946...01d65f0. Read the comment docs.

[mattrubin]

I'm sorry for the long delay in addressing this issue!

After much thought, I've opened a new PR which adds a settings screen that allows the user to choose whether they prefer passwords rendered in groups of two digits or groups of three. I'd love to hear feedback from all the folks who prefer groups of three on whether this new approach feels like a satisfactory solution.

[mattrubin]

This PR has been superseded by #290. Thank you to @beaucollins for this proposal!