Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asks user for confirmation before deleting token from device #217

Merged
merged 11 commits into from
Apr 24, 2018

Conversation

beaucollins
Copy link
Collaborator

@beaucollins beaucollins commented Oct 27, 2017

Uses UIAlertController to present a UIActionSheet style dialog asking the user if they
want to remove the token.

confirmation

Fixes #198

Uses UIAlertController to present a UIActionSheet style dialog asking the user if they
want to remove the token.
@beaucollins
Copy link
Collaborator Author

@mattrubin this should help prevent any accidental deletions.

I think it could be interesting to explore making an "undo" user flow possible versus asking for confirmation.

@codecov
Copy link

codecov bot commented Nov 8, 2017

Codecov Report

Merging #217 into develop will decrease coverage by 0.43%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #217      +/-   ##
===========================================
- Coverage    40.64%   40.21%   -0.44%     
===========================================
  Files           36       36              
  Lines         2244     2268      +24     
===========================================
  Hits           912      912              
- Misses        1332     1356      +24
Impacted Files Coverage Δ
Authenticator/Source/AppController.swift 22.92% <0%> (-4.14%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bc9f54...54c2b6c. Read the comment docs.

@mattrubin mattrubin added this to the 2.1 milestone Nov 8, 2017
@mattrubin mattrubin modified the milestones: 2.0.3, 2.next Apr 24, 2018
@mattrubin
Copy link
Owner

I've updated this PR to tweak the confirmation message text, and to present the confirmation in the more prominent alert style.

Screenshot of token deletion confirmation alert.

@mattrubin mattrubin merged commit 9fc8946 into develop Apr 24, 2018
@mattrubin mattrubin deleted the feature/confirm-before-delete branch April 24, 2018 17:42
@mattrubin mattrubin modified the milestones: 2.next, 2.0.5 Sep 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants