Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release OneTimePassword 3.1.3 #181

Merged
merged 6 commits into from
Apr 29, 2018
Merged

Release OneTimePassword 3.1.3 #181

merged 6 commits into from
Apr 29, 2018

Conversation

mattrubin
Copy link
Owner

@mattrubin mattrubin commented Apr 29, 2018 •
edited

Before merging:

  • Update the Info.plist
    • Bump the short version number
    • Bump the full build number
  • Update the pod spec
    • Bump the version number
    • Ensure the dependency versions match the Cartfile
    • Make sure the deployment targets match the Xcode project
    • Make sure swift_version specification and the .swift-version file are both correct
  • Test all builds methods
    • Ensure all Xcode schemes build and tests pass
    • carthage build --no-skip-current
    • pod spec lint (against a release candidate tag)
  • Make sure the changelog is up to date
    • Entries
    • Version number
    • Diff links
    • Release date
  • Update the README (as necessary)
    • Update the platform compatibility badges
    • Update the installation instruction version numbers
    • Update the usage note about version compatibility
    • Update the usage example code

After merging:

  • Tag the release commit
  • Publish the GitHub release
  • Push the updated podspec (pod trunk push)

houndci-bot
houndci-bot reviewed Apr 29, 2018
View reviewed changes
Tests/KeychainTests.swift
@@ -281,7 +284,8 @@ class KeychainTests: XCTestCase {
let persistentRef = try addKeychainItem(withAttributes: keychainAttributes)

XCTAssertThrowsError(try keychain.persistentToken(withIdentifier: persistentRef))
XCTAssertThrowsError(try keychain.allPersistentTokens())
// TODO: Restore deserialization error handling in allPersistentTokens()
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Todo Violation: TODOs should be resolved (Restore deserialization error ...). (todo)

Tests/KeychainTests.swift
@@ -264,7 +266,8 @@ class KeychainTests: XCTestCase {
let persistentRef = try addKeychainItem(withAttributes: keychainAttributes)

XCTAssertThrowsError(try keychain.persistentToken(withIdentifier: persistentRef))
XCTAssertThrowsError(try keychain.allPersistentTokens())
// TODO: Restore deserialization error handling in allPersistentTokens()
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Todo Violation: TODOs should be resolved (Restore deserialization error ...). (todo)

Tests/KeychainTests.swift
@@ -247,7 +248,8 @@ class KeychainTests: XCTestCase {
let persistentRef = try addKeychainItem(withAttributes: keychainAttributes)

XCTAssertThrowsError(try keychain.persistentToken(withIdentifier: persistentRef))
XCTAssertThrowsError(try keychain.allPersistentTokens())
// TODO: Restore deserialization error handling in allPersistentTokens()
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Todo Violation: TODOs should be resolved (Restore deserialization error ...). (todo)

Tests/KeychainTests.swift
@@ -231,7 +231,8 @@ class KeychainTests: XCTestCase {
let persistentRef = try addKeychainItem(withAttributes: keychainAttributes)

XCTAssertThrowsError(try keychain.persistentToken(withIdentifier: persistentRef))
XCTAssertThrowsError(try keychain.allPersistentTokens())
// TODO: Restore deserialization error handling in allPersistentTokens()
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Todo Violation: TODOs should be resolved (Restore deserialization error ...). (todo)

Sources/Keychain.swift
// tokens as possible.
// TODO: Restore deserialization error handling, in a way that provides info on the failure reason and allows
// the caller to choose whether to fail completely or recover some data.
return Set(allItems.flatMap({ try? PersistentToken.init(keychainDictionary:$0) }))
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Explicit Init Violation: Explicitly calling .init() should be avoided. (explicit_init)

Sources/Keychain.swift
let allItems = try allKeychainItems()
// This code intentionally ignores items which fail deserialization, instead opting to return as many readable
// tokens as possible.
// TODO: Restore deserialization error handling, in a way that provides info on the failure reason and allows
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Todo Violation: TODOs should be resolved (Restore deserialization error ...). (todo)

houndci-bot
houndci-bot reviewed Apr 29, 2018
View reviewed changes
Tests/KeychainTests.swift
@@ -281,7 +284,8 @@ class KeychainTests: XCTestCase {
let persistentRef = try addKeychainItem(withAttributes: keychainAttributes)

XCTAssertThrowsError(try keychain.persistentToken(withIdentifier: persistentRef))
XCTAssertThrowsError(try keychain.allPersistentTokens())
// TODO: Restore deserialization error handling in allPersistentTokens()
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Todo Violation: TODOs should be resolved (Restore deserialization error ...). (todo)

Tests/KeychainTests.swift
@@ -264,7 +266,8 @@ class KeychainTests: XCTestCase {
let persistentRef = try addKeychainItem(withAttributes: keychainAttributes)

XCTAssertThrowsError(try keychain.persistentToken(withIdentifier: persistentRef))
XCTAssertThrowsError(try keychain.allPersistentTokens())
// TODO: Restore deserialization error handling in allPersistentTokens()
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Todo Violation: TODOs should be resolved (Restore deserialization error ...). (todo)

Tests/KeychainTests.swift
@@ -247,7 +248,8 @@ class KeychainTests: XCTestCase {
let persistentRef = try addKeychainItem(withAttributes: keychainAttributes)

XCTAssertThrowsError(try keychain.persistentToken(withIdentifier: persistentRef))
XCTAssertThrowsError(try keychain.allPersistentTokens())
// TODO: Restore deserialization error handling in allPersistentTokens()
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Todo Violation: TODOs should be resolved (Restore deserialization error ...). (todo)

@codecov
Copy link

codecov bot commented Apr 29, 2018 •
edited

Codecov Report

Merging #181 into release will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           release     #181      +/-   ##
===========================================
+ Coverage    97.19%   97.22%   +0.03%     
===========================================
  Files            6        6              
  Lines          392      397       +5     
===========================================
+ Hits           381      386       +5     
  Misses          11       11
Impacted Files Coverage Δ
Sources/Keychain.swift 92.56% <100%> (+0.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c091c8...e1d7d17. Read the comment docs.

@mattrubin mattrubin merged commit a1bdada into release Apr 29, 2018
@mattrubin mattrubin added this to the 3.1.3 milestone Sep 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@houndci-bot houndci-bot houndci-bot left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.1.3
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mattrubin @houndci-bot