Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the .swift-version file #204

Merged
merged 1 commit into from Apr 27, 2019
Merged

Remove the .swift-version file #204

merged 1 commit into from Apr 27, 2019

Conversation

mattrubin
Copy link
Owner

CocoaPods now supports specifying Swift versions in the podspec, so usage of this file by CocoaPods is deprecated.

Also, it appears this method of specifying a Swift version was never fully supported when integrating a pod into a project:

Note: While the pod author was initially allowed to publish their podspec using .swift-version file or --swift-version parameter, neither of them are preserved when a consumer is integrating their pod, therefore it is imperative to motivate pod authors to update their podspec to use the swift_versions DSL going forward.

CocoaPods/CocoaPods#8191 (comment)

CocoaPods now supports specifying Swift versions in the podspec, so usage of this file by CocoaPods is deprecated.

Also, it appears this method of specifying a Swift version was never fully supported when integrating a pod into a project:
CocoaPods/CocoaPods#8191 (comment)
@codecov
Copy link

codecov bot commented Apr 27, 2019

Codecov Report

Merging #204 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #204   +/-   ##
========================================
  Coverage    99.34%   99.34%           
========================================
  Files            6        6           
  Lines          153      153           
========================================
  Hits           152      152           
  Misses           1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0406db1...9692732. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Apr 27, 2019

Codecov Report

Merging #204 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #204   +/-   ##
========================================
  Coverage    99.34%   99.34%           
========================================
  Files            6        6           
  Lines          153      153           
========================================
  Hits           152      152           
  Misses           1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0406db1...9692732. Read the comment docs.

@mattrubin mattrubin merged commit d9f8753 into develop Apr 27, 2019
@mattrubin mattrubin deleted the swift-version branch April 27, 2019 15:52
@mattrubin mattrubin added this to the 3.1.6 milestone Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant