Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coming Soon Show Movies - Recently Added & Newest TV Show Poster/Backgrounds Issue #45

Closed
titelies opened this issue Mar 8, 2021 · 13 comments
Closed

Coming Soon Show Movies - Recently Added & Newest TV Show Poster/Backgrounds Issue #45

titelies opened this issue Mar 8, 2021 · 13 comments

Comments

@titelies
Copy link

titelies commented Mar 8, 2021

I tend to use ALL in the Show Movies Coming Soon Advanced dropdown menu cause Plex seems to always have the wrong info for Recently Added and Newest, old movies get mistakenly added, not sure if others have noticed this as well.
However, the issue that I'm reporting is when I tested the Recently Added and Newest dropdown choices, instead of PMPD displaying the TV Show posters, it posts random background images that I didn't select for my TV Shows... weird! Show Movies: Unwatched and All display TV Show posters correctly but the bottom 2 choices from the dropdown menu show random incorrect background images as seen in these screenshots:
https://i.imgur.com/A2gGxGJ.jpg
https://i.imgur.com/0UWUa6E.jpg
https://i.imgur.com/35ka0UL.jpg
@ZeroCoolGOS
Copy link

Interesting.

I have not actually tested the other options, so that is my bad.

I will have a look this week and see what is going on.

@titelies
Copy link
Author

titelies commented Mar 8, 2021

No worries Geoff, just trying to help. Upon further investigation, the images showing up for Recently Added & Newest are Episode Posters, not TV Show posters.

@ZeroCoolGOS
Copy link

ZeroCoolGOS commented Mar 8, 2021 •
edited

Ah. Yes, I see what your saying.

All and Unwatched seem to be working correctly, but when you select Newest or Recently Added then you get the TV show episode art.

I will dig in the logs now and see what I can find.

*** Update ***
I have found out why it's showing the "Episode Poster" when set to Newest or Recently added.
It has to do with the metadata coming back from the API.

Now that I know what the issue is I will work on building a fix for this.

@ZeroCoolGOS
Copy link

@titelies

When displaying posters for TV shows. Would you always want to use the TV Show proper poster or would you also want the option to set for the "episode poster" or "season poster"?

@titelies
Copy link
Author

titelies commented Mar 8, 2021

@titelies

When displaying posters for TV shows. Would you always want to use the TV Show proper poster or would you also want the option to set for the "episode poster" or "season poster"?

I would most likely use the TV Show poster but the Season Poster sounds like be a nice option as well. Episode Poster would not work for my particular case cuz my TV is displayed vertically and the Episode posters are horizontal.

@ZeroCoolGOS
Copy link

Ok, cool.

I have found the issue and will have it fixed in my next push as well as add an option to set the type (Episode, Season, Series) just like how the Now Playing has that option.

The only thing I can see is when you use TV shows as part of your Coming Soon, the same poster can come up more often then others if you have added multiple episodes as the changes get a lot higher you will hit one of the episodes, but that should not be too big of an issue.

@titelies
Copy link
Author

titelies commented Mar 8, 2021

Thanks for the TV Show poster info, sounds like I'll be choosing the Season Posters to get some variation. Much appreciated!

ZeroCoolGOS added a commit to ZeroCoolGOS/Plex-Movie-Poster-Display that referenced this issue Mar 9, 2021
@ZeroCoolGOS
v2.10.0 Community Updates**\
07b6ea4 
Refactor - Remove all Plex Assets (Issue MattsShack#38)

    Update to conform to PLEX trademarks and guidelines
    - Remove all PLEX images and assets
    - Change color scheme
    - Rename project
- Create new set of 'clean' css files for the settings and the display pages.
- Change out hard coded naming of project to variables
- Remove all PLEX assets from assets folder
- Segregation of PLEX settings into a dedicated PLEX page
- Replace color scheme with new design
- Clean up none required 'extra' formatting that had no impact on end product
- Restructure some 'duplicate' components to be more central and reusable (eg. 'Save Changes' button)
- Retained a similar skeletal structure, but streamlined and made enhancements
- Update/reformat preexisting stock images for use for icons.

ToDo:
- Continue to refactor and rename some CSS elements.
- Clean out more unnecessary code in php and css files.
- Update more of the color and font once updated design change becomes available
- Continue to Move/Remove PLEX references and keep isolated to a limited locations within the code.

Bug - Coming Soon Show Movies - Recently Added & Newest TV Show Poster/Backgrounds (Issue MattsShack#45)
- Add better logic to allow for the information of the media when using 'Recently Added' and 'Newest' for TV shows as the xml from the API changes between these options.
- Add a dropdown option in 'Coming Soon' (same as Now Showing) for TV Shows to allow settings for Episode/Season/Series
- Add fixes for how the poster is found for TV Shows if a poster is not found it will try to check its next level up

Updates and Bug Fixes:
- Fix issue with the 'Custom Image Upload' and 'Custom Image Select' not working correctly
- Start to build out more 'tests' for better debugging of future issues.
@ZeroCoolGOS ZeroCoolGOS mentioned this issue Mar 9, 2021
Merged
@ZeroCoolGOS
Copy link

This fix should now be in v2.10.

Give it a go and let me know if its working correctly for you.

@titelies
Copy link
Author

Working well in Show Media: Newest and have decided to go with the Seasons Poster... Great idea Geoff!

@titelies
Copy link
Author

FYI: Successfully tested with new Plex TV Series (BETA) Agent

@ZeroCoolGOS
Copy link

Plex TV Services (BETA) agent?

@titelies
Copy link
Author

Yep, just released for Plex Pass users in the past week: https://forums.plex.tv/t/beta-new-plex-tv-series-scanner/696242

@ZeroCoolGOS
Copy link

Interesting. I will have to dig into that more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@titelies @ZeroCoolGOS