Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PMPD Pop-up Window with "S" Key #70

Closed
titelies opened this issue Mar 25, 2021 · 5 comments
Closed

PMPD Pop-up Window with "S" Key #70

titelies opened this issue Mar 25, 2021 · 5 comments
Assignees
@ZeroCoolGOS
Labels
enhancement

Comments

@titelies
Copy link

I recently learned by accident that if I click on the "s" key on my keyboard, a NGINX pop-up window appears. I wonder if that pop-up window can be used for another reason such as metadata info or anything else that someone feels would be worthwhile... Just a thought! https://i.imgur.com/6K3Yr1u.png
@ZeroCoolGOS
Copy link

I remember seeing something in the code about that.

I will look into that today and see what is going on.

@ZeroCoolGOS
Copy link

I have identified the issue with the 'S' option and will have an update for it in 2.11.3.

The reason behind it was to have a popup of the 'admin' page but now I have remapped it to the settings page for now.

In the future we could look at adding different hidden keys is requested.

ZeroCoolGOS added a commit to ZeroCoolGOS/Plex-Movie-Poster-Display that referenced this issue Mar 26, 2021
@ZeroCoolGOS
v2.11.3 Community Updates
29c6079 
Enhancement: Full Screen Poster (Issue MattsShack#57)
- BUG: When using 'Full Screen Art' poster gets trimmed & depending on custom image size image is not scaled to window size.
    - Fix 1 (Implemented): Change CSS in index.php from 'auto 100%' to 'contain', but that does not fully scale movie poster as desired.
    - Fix 2 (Future): Look at different options for different modes.
    - Fix 3 (Future): In 'Poster Mode' look at setting image size explicit.
    - Fix 4 (Future): Adjust size dimensions of image based on orientation of the screen.

PMPD Pop-up Window with 'S' Key (Issue MattsShack#70)
- Update 'S' key to bring up the settings pages.
- Adjust how the CSS displays the iFrame and remove un-required scroll bar for main page.
- Change script from using 'if' statement to 'switch' statement so that adding future keys is a bit simpler.
- TODO: Look at other 'keys' to add to bring up special stats pages depending on mode?

Enhancement: Cache Config Options (Issue MattsShack#63)
- Remove empty folders after Clear Cache

Updates and Bug Fixes:
- Update Docker system to allow SSH into container for more debugging options.
@ZeroCoolGOS ZeroCoolGOS mentioned this issue Mar 26, 2021
Merged
@titelies
Copy link
Author

Love the new feature @ZeroCoolGOS

@MattsShack
Copy link
Owner

Nice addition.

@ZeroCoolGOS
Copy link

Nice addition.

@MattsShack

Lol. Ya. It's a nice feature. You wrote it. I just fixed it with the change to the setting page. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ZeroCoolGOS ZeroCoolGOS

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@MattsShack @titelies @ZeroCoolGOS