Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move stdin argument to end of exec command, fixes #9 #10

Merged
merged 1 commit into from
Aug 5, 2017

Conversation

nweddle
Copy link
Contributor

@nweddle nweddle commented Aug 4, 2017

Fixes #9

Looks like this was caused by the version of rubocop (0.49.1) included in ChefDK 2.0.13. The update to rubocop[1] has enforced proper usage of the --stdin flag:

-s/--stdin requires exactly one path.

This change moves stdin to the end of the exec command, to comply with the change in rubocop.

[1] rubocop/rubocop#4226

@mattstratton
Copy link
Owner

The only thing that doesn't make sense to me is that we never call rubocop directly; isn't it wrapped and pinned in cookstyle? If this fixes the chefdk issue, that's awesome, but I want to understand why.

@mattstratton
Copy link
Owner

I'm going to merge this in, and then I should be able to cut a new release later tonight (I just rebuilt my workstation and I don't know that I have all my apm stuff set up properly, heh)

@mattstratton mattstratton merged commit a0f8440 into mattstratton:master Aug 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants