Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retract v1.0.3 #25

Open
wants to merge 1 commit into
base: v1
Choose a base branch
from
Open

Retract v1.0.3 #25

wants to merge 1 commit into from

Conversation

SuperQ
Copy link

@SuperQ SuperQ commented Jan 11, 2024

  • Retract the broken v1.0.3 tag.
  • Bump the Go version to support retract directive.

* Retract the broken v1.0.3 tag.
* Bump the Go version to support `retract` directive.

Signed-off-by: SuperQ <superq@gmail.com>
@SuperQ
Copy link
Author

SuperQ commented Jan 11, 2024

Note, the go directive change is required for supporting the retract directive. It is also advisory for Go versions before 1.21.

@matttproud
Copy link
Owner

OK. It's pushing the version as little as required? I think that's OK. Let me ruminate on this a little and then get back to you soon.

@SuperQ
Copy link
Author

SuperQ commented Jan 11, 2024

Yes, updating the Go minimum compatibility directive is required as the retract does not work before Go 1.16.

The retract directive was added in Go 1.16. Go 1.15 and lower will report an error if a retract directive is written in the main module’s go.mod file and will ignore retract directives in go.mod files of dependencies.

Updating minimum Go version directives is a perfectly fine and normal to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants