Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Go modules #26

Open
wants to merge 1 commit into
base: v1
Choose a base branch
from
Open

Update Go modules #26

wants to merge 1 commit into from

Conversation

SuperQ
Copy link

@SuperQ SuperQ commented Jan 11, 2024

Update Go module dependencies to latest releases.

  • Update Go minimum version to 1.11 to satisfy xerrors requirement.

Update Go module dependencies to latest releases.
* Update Go minimum version to 1.11 to satisfy xerrors requirement.

Signed-off-by: SuperQ <superq@gmail.com>
@matttproud
Copy link
Owner

I am planning on retiring the v1 branch (unless someone gives me a very good reason). v1 will remain, though. I'm a bit concerned about extra churn there. The last time we updated the respective libraries in v1, it resulted in considerable global breakage. I suspect it's harmless to leave these dependencies pinned as-is. Are there several known reasons why the dependencies in v1 need to be updated?

@SuperQ
Copy link
Author

SuperQ commented Jan 11, 2024

Updating the dependency versions, without changing which library, is a standard thing to do in Go modules. It signals to downstream Go module users to update their transitive dependencies.

In this case, we're not changing the library fully like was done for v2. We're only updating the existing library, which is backwards compatible.

However, I would suggest we publish the retract change first, so that I can apply Go 1.16 formatting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants