Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue #93 - cleanup error hiding exception details #101

Closed
wants to merge 3 commits into from

Conversation

tlynn
Copy link

@tlynn tlynn commented Mar 14, 2015

This is the suggested fix from the first comment on issue #93, with a test demonstrating the problem.

@tlynn
Copy link
Author

tlynn commented Mar 14, 2015

Hmmm, looks like I need to provide Py 3 compatibility.

@tlynn
Copy link
Author

tlynn commented Oct 28, 2015

Ping! Would you mind looking at this, please?

@davidism davidism added this to the 0.10.0 milestone May 23, 2024
@davidism
Copy link
Member

I'm not clear how this issue can happen. The test is very complex, and does not seem to do anything about host not having a sock attribute. The following code does not seem to have any issue. If you still have an issue, please open a new issue with a minimal reproducible example and clear description.

from flask import Flask
from flask_mail import Mail, Message

app = Flask(__name__)
app.config.update({
    "MAIL_HOST": "127.0.0.1",
    "MAIL_PORT": 1025,
})
mail = Mail(app)

with app.app_context():
    with mail.connect() as c:
        c.send(Message("test", sender="test", recipients=["test"]))

@davidism davidism closed this May 23, 2024
@davidism davidism removed this from the 0.10.0 milestone May 23, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants