Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notifications and better error handling #31

Merged
merged 8 commits into from
Sep 30, 2022
Merged

Conversation

mattwebbio
Copy link
Owner

Closes #26
Closes #30
Closes #29

@mattwebbio mattwebbio marked this pull request as draft September 16, 2022 15:53
@codecov-commenter
Copy link

codecov-commenter commented Sep 16, 2022

Codecov Report

Base: 97.32% // Head: 100.00% // Increases project coverage by +2.67% 🎉

Coverage data is based on head (ff271a2) compared to base (6926670).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           master       #31      +/-   ##
===========================================
+ Coverage   97.32%   100.00%   +2.67%     
===========================================
  Files           4         6       +2     
  Lines         112       160      +48     
  Branches       19        34      +15     
===========================================
+ Hits          109       160      +51     
+ Misses          3         0       -3     
Impacted Files Coverage Δ
src/client.ts 100.00% <100.00%> (ø)
src/config.ts 100.00% <100.00%> (ø)
src/index.ts 100.00% <100.00%> (+27.27%) ⬆️
src/log.ts 100.00% <100.00%> (ø)
src/notify.ts 100.00% <100.00%> (ø)
src/sync.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mattwebbio mattwebbio force-pushed the addNotifications branch 6 times, most recently from 0dead18 to 98a4ac7 Compare September 18, 2022 05:04
src/notify.ts Fixed Show fixed Hide fixed
src/notify.ts Fixed Show fixed Hide fixed
@mattwebbio mattwebbio marked this pull request as ready for review September 30, 2022 23:36
@mattwebbio mattwebbio merged commit 411e398 into master Sep 30, 2022
@mattwebbio mattwebbio deleted the addNotifications branch September 30, 2022 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Container fails if target unavailable Provide TZ as environment variable Additional notification options
2 participants