Fix shellcheck violations and remove trailing semicolons #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most of the issues flagged were about missing quotes, but there were also some cases of unneeded uses of `$?`, which is easy to break on refactoring. It's much better to merge the `if` with the command so they are not broken apart by some other command. Trailing semicolons are also not a shellscript idiom, so that was removed.
Closed
|
Hi @Mange, thanks for improving this script! Did not think about checking it with shellcheck.. :p |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the issues flagged were about missing quotes, but there were also some cases of unneeded uses of
$?, which is easy to break on refactoring. It's much better to merge theifwith the command so they are not broken apart by some other command.Trailing semicolons are also not a shellscript idiom, so that was removed.