feat: make review function return feedback

mattzcarey · Aug 10, 2023 · c58fcee · c58fcee
1 parent 3d093f7
commit c58fcee
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/services/core/functions/review-lambda/index.ts b/services/core/functions/review-lambda/index.ts
@@ -29,7 +29,11 @@ export const main = async (event: APIGatewayProxyEvent) => {
     );
 
     process.env["OPENAI_API_KEY"] = keyValue;
-    return await review(inputBody.args, inputBody.files);
+    const reviewResponse = await review(inputBody.args, inputBody.files);
+    return Promise.resolve({
+      statusCode: 200,
+      body: reviewResponse,
+    });
   } catch (err) {
     console.error(err);
 

diff --git a/src/review/index.ts b/src/review/index.ts
@@ -1,4 +1,3 @@
-import { exit } from "process";
 import { commentOnPR as commentOnPRGithub } from "../common/ci/github/commentOnPR";
 import { commentPerFile } from "../common/ci/github/commentPerFile";
 import { commentOnPR as commentOnPRGitlab } from "../common/ci/gitlab/commentOnPR";
@@ -13,7 +12,7 @@ import { filterFiles } from "./prompt/filterFiles";
 export const review = async (
   yargs: ReviewArgs,
   files: ReviewFile[]
-): Promise<void> => {
+): Promise<string | undefined> => {
   logger.debug(`Review started.`);
   logger.debug(`Model used: ${yargs.model}`);
   logger.debug(`Ci enabled: ${yargs.ci}`);
@@ -29,7 +28,7 @@ export const review = async (
 
   if (filteredFiles.length == 0) {
     logger.info("No file to review, finishing review now.");
-    return;
+    return undefined;
   }
 
   logger.debug(
@@ -66,4 +65,6 @@ export const review = async (
   if (isCi === PlatformOptions.GITLAB) {
     await commentOnPRGitlab(response, signOff);
   }
+
+  return response;
 };