mocha.path option should be used to find the tests

[eramitmittal]

mocha.path option should be treated as relative to the workspace root folder

---

This change is 

[maty21]

I'm not sure sometimes you wish to use global mocha.
did you saw any problem with this?

[maty21]

btw on which configuration you run sidebar for typescript there is an open issue about running mocha sidebar with typescript. but I haven't looked at it yet

[eramitmittal]

Hi,
I am not aware about the mocha sidebar issue with typescript. I will try and have a look.
The problem I faced with my project setup is:

1. My project uses mocha version 5.2.0
2. Sidebar extension ships with mocha version 2.5.3
3. If I specify full path to local mocha installation using mocha.path option, sidebar extension loads the correct version
4. If I specify relative path, sidebar extension always loads the mocha version shipped with the extension
5. I want to specify relative path so that I can commit this in version control. My team members in this way will not be required to manually specify the full path as per their machine.

Regarding your concern that sometimes people want to use global mocha, I can modify the code to use path.isAbsolute to check if the configuration really is relative or an absolute path

[eramitmittal]

I have updated the code, please review

[eramitmittal]

hi, did you get a chance to review this (adoption of sidebar extension in my team is blocked on this issue, I hope you understand :))

[eramitmittal]

Hi, did you get a chance to review this?

[maty21]

Yep I think about it coz I'm not sure if it's the correct way for handling this . Is there something u can't do with the current code ?

…

On Tue, Jul 24, 2018, 1:57 PM Amit Mittal ***@***.***> wrote: Hi, did you get a chance to review this? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#127 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AE_nubIez4NnVXJ5C-lkfS3ibjFsuILVks5uJv2NgaJpZM4VQvPi> .

[eramitmittal]

Yes, without this change I am not able to specify relative path to 'local' mocha installation.
Ability to specify relative path is important so that the setting can be committed to version control.
Otherwise I have to use 'absolute' path which is off-course different on different machines. Due to this each and every dev in my team will be required to manually specify the path. This is undesirable.

My patch is just 'completing' the functionality of mocha.path setting.
Since mocha.path already allows specification of absolute path, it is only natural that it should also support relative path.

[eramitmittal]

Interestingly, documentation for mocha.path suggests that user can provide relative path.
But it does not work.
My patch is solving this by treating a relative path (if specified) w.r.t. workspace root folder

[eramitmittal]

Hi @maty21 , Any update on this please?

[maty21]

I'll will try my best to solve it o know your PR is open for a pretty long time and I hope to find the way for fixing it for the next couple of weeks

…

On Fri, Dec 21, 2018, 9:50 AM Amit Mittal ***@***.***> wrote: Hi @maty21 <https://github.com/maty21> , Any update on this please? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#127 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AE_nua2fZj0Zogj1YDfaOaMm4ymwn9UXks5u7JLagaJpZM4VQvPi> .

[maty21]

Reviewed 1 of 1 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved