Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use only Base16 colors in p10k config #20

Closed
matyama opened this issue Apr 21, 2022 · 1 comment
Closed

Use only Base16 colors in p10k config #20

matyama opened this issue Apr 21, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@matyama
Copy link
Owner

matyama commented Apr 21, 2022

p10k.zsh should only use BASE16_BASE* variables when setting background/foreground colors. d123775 introduces these variables and used them in the most important cases but not all.

Replace all remaining hard-coded values by BASE16_BASE*. See these occurrences by running:

rg '(FOREGROUND|BACKGROUND|COLOR)=\d+$' .config/zsh/p10k.zsh
@matyama matyama added the enhancement New feature or request label Apr 21, 2022
matyama added a commit that referenced this issue Apr 22, 2022
@matyama
Change p10k prompt style to Rainbow
4b1d786 
 - Rainbow prompt style respects terminal's color palette and thus does
   not require custom background/foreground changes in `p10k.zsh`. This
   addresses issue #20.
 - Because custom config is no longer required, this commit solves issue
   #21
 - Note: An alternative setup which also respects Base16 terminal colors
   is *Lean* prompt style but only in combination with *8 colors*
 - Finally, this commit updates and extends relevant section in README
@matyama
Copy link
Owner Author

matyama commented Apr 22, 2022

No longer an issue, addressed by 4b1d786.

@matyama matyama closed this as completed Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@matyama