Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AboutMocks: simpleAnonymousMock() [cosmetic] #23

Closed
kjc opened this issue Nov 13, 2011 · 3 comments
Closed

AboutMocks: simpleAnonymousMock() [cosmetic] #23

kjc opened this issue Nov 13, 2011 · 3 comments

Comments

@kjc
Copy link
Contributor

kjc commented Nov 13, 2011

Two cosmetic gripes: The TODO comment on line 12 says to ponder ``why this assertion was failing'', when there is no failing assertion. Also, the only koan in the file comes before the interface and class it refers to.

@mcornell
Copy link
Contributor

Just a thought...for something cosmetic, fork the project, and fix it, then put in a pull request.

@matyb
Copy link
Owner

matyb commented Nov 14, 2011

All better. This was one of the first koans developed, and was a tad neglected. I think you'll agree it's improved.

Off the topic, when you have a moment you may want to check out:
http://www.yuiblog.com/blog/2011/06/09/video-f2esummit2011-donnelly/

She gave me the idea of forking for every conceivable excuse. It is really helpful, and easily one of git's strongest points.

@matyb matyb closed this as completed Nov 14, 2011
@kjc
Copy link
Contributor Author

kjc commented Nov 14, 2011

Thanks for the link. I'm downloading her video now.

And thanks for fixing all this so fast. I certainly didn't expect you would dive on these the night I submitted them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants