Skip to content
This repository has been archived by the owner on Feb 5, 2021. It is now read-only.

Check of nesting depths may fail #5

Closed
matze-dd opened this issue Feb 5, 2019 · 4 comments
Closed

Check of nesting depths may fail #5

matze-dd opened this issue Feb 5, 2019 · 4 comments
Labels
bug Something isn't working

Comments

@matze-dd
Copy link
Owner

matze-dd commented Feb 5, 2019

In the section on implementation issues of README.md, checks for nesting depths of braces and environments have been mentioned. They do fail, if braces or environment frames are inserted via expansion
of a declared macro.

One could reject recursive declaration of macros, but this would reduce
flexibility.

@matze-dd matze-dd added the bug Something isn't working label Feb 5, 2019
@matze-dd
Copy link
Owner Author

matze-dd commented Feb 5, 2019

Currently, the checks are performed after removal of % comments.
A fix would be to re-check, whenever a brace is inserted by a macro expansion, which in turn is easily detected.

@matze-dd
Copy link
Owner Author

Fixed with release 1.5.2

@matze-dd
Copy link
Owner Author

The version from release 1.5.2 does not check inclusion of [] brackets and \begin or \end of environments.
Furthermore, we also should perform the tests at replacements for "normal" and equation environments with fixed text.

@matze-dd matze-dd reopened this Feb 25, 2019
matze-dd added a commit that referenced this issue Feb 26, 2019
matze-dd added a commit that referenced this issue Feb 26, 2019
@matze-dd
Copy link
Owner Author

Closed in master after release 1.5.2

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant