chore: stop sorting scripts #31
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanmorley
commented
Nov 12, 2020
package.json
Outdated
| @@ -28,7 +28,7 @@ | |||
| "test:unit": "jest" | |||
| }, | |||
| "dependencies": { | |||
| "sort-package-json": "1.46.1" | |||
| "sort-package-json": "cvent/sort-package-json#fields-option" | |||
There was a problem hiding this comment.
I'll update this if/when the keithamus/sort-package-json#206 PR gets merged
jonathanmorley
force-pushed
the
master
branch
from
9a9f56d
to
d6450fc
Compare
jonathanmorley
force-pushed
the
master
branch
from
d6450fc
to
05b4920
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking change.
We use npm-run-all for running scripts inside of the package.json.
This treats the order of keys in
scriptsas being meaningful, especially when running sequentially.Also, we tend to organise our scripts based on the order the scripts are executed in the project lifecycle, which is not always alphabetical.