Fix CStorable default implementation #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maurer
added a commit
that referenced
this pull request
Jan 17, 2015
Fix CStorable default implementation
|
Thank you for merging my patch. Could you upload a new version (0.1.1?) on Hackage for this package? Mine cannot work without this fix. |
|
Sorry for the delay, your fix should be on hackage now: http://hackage.haskell.org/package/c-storable-deriving |
|
No problem ;) Thank you! |
hsyl20
added a commit
to hsyl20/c-storable-deriving
that referenced
this pull request
Oct 29, 2015
With Generics, fields are arbitrarily nested with the binary operator (:*:). Hence we cannot assume a left fold as we did until now to compute field offsets. With this patch, we parameterize most operations of GCStorable with an initial offset. The initial offset is only set to 0 for the whole data structure: i.e. in CStorable default methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this is a small patch to fix a copy-paste error in the default implementation of the CStorable instance.