Proyecto terminado y funcional #20
Conversation
…ArCiGo Setup of automation framework
…ArCiGo Add of class content
Framework
Changes on URL_HELP in credentials.properties Changes on FindBy spIconLogo and BASE_URL in SpotifyHelpPage.java
Add SpotifyIconTest.java
Agrega HelpPageTest
ArCiGo
added
enhancement
| public class GetSpotifyTest extends BaseTest{ | ||
| private String spotifyUrl; | ||
|
|
||
| @BeforeMethod |
There was a problem hiding this comment.
Remove annotation and call the method inside of every test method
| spotifySignUpPage.clickOnRegistrateButton(); | ||
| List<String> listOfErrors = spotifySignUpPage.getAllSpotifySignUpFormErrorMessages(); | ||
|
|
||
| Assert.assertFalse(listOfErrors.isEmpty(), "No arrojo errores"); |
There was a problem hiding this comment.
You also need to verify the errors thrown by the form, not only the size of the list
| @Test(description = "TC_US3_002/Campos de registro de obtén spotify gratis se envían llenos y sin validar captcha", alwaysRun = true, priority = 0) | ||
| public void spotifySignUpNoCaptcha(){ | ||
|
|
||
| PropertyReader propertyReader = new PropertyReader(); |
There was a problem hiding this comment.
Declare the PropertyReader object as global
| public void spotifySignUpFuturo(){ | ||
|
|
||
| PropertyReader propertyReader = new PropertyReader(); | ||
| String email=propertyReader.getProperty("credentials.properties", "TC_US_03_003_EMAIL"); |
There was a problem hiding this comment.
Why are you repeating the same variables for each test method?
Create a list of user values where you can store the values from the credentials.properties file and call the list (myAwesomeList.get(0)) in the methods who receive the data.
| @Test(alwaysRun = true,description = "TC_US4_001/ Llenar el formulario para crear cuenta nueva") | ||
| public void spotifySignNoGender(){ | ||
| PropertyReader propertyReader = new PropertyReader(); | ||
| String email=propertyReader.getProperty("credentials.properties", "TC_US_04_001_EMAIL"); |
There was a problem hiding this comment.
Why are you repeating the same variables for each test method?
Create a list of user values where you can store the values from the credentials.properties file and call the list (myAwesomeList.get(0)) in the methods who receive the data.
| private String spotifyUrl; | ||
|
|
||
| @BeforeMethod | ||
| public void initSetup(){ |
There was a problem hiding this comment.
Remove annotation and call the method inside of every test method
| spotifySignUpPage.clickOnRegistrateButton(); | ||
| List<String> listOfErrors = spotifySignUpPage.getAllSpotifySignUpFormErrorMessages(); | ||
|
|
||
| Assert.assertFalse(listOfErrors.isEmpty(), "No arrojo errores"); |
There was a problem hiding this comment.
Check the grammar and orthography
| private SpotifyHelpPage spotifyHelpPage; | ||
|
|
||
| @BeforeTest | ||
| public void initSetup() { |
There was a problem hiding this comment.
Remove annotation and call the method inside of every test method
| driver.navigate().to(spotifyUrl); | ||
| spotifyHomePage = new SpotifyHomePage(driver); | ||
|
|
||
| Assert.assertTrue(spotifyHomePage.isLoaded(), "Página principal no se cargo correctamente"); |
There was a problem hiding this comment.
Check the grammar and orthography
| spotifyHomePage.clickOnSpotifyIcon(); | ||
|
|
||
| Assert.assertTrue(spotifyHomePage.isLoaded(), "Página principal no se cargo correctamente"); | ||
| Assert.assertEquals(spotifyHomePage.BASE_URL, driver.getCurrentUrl(), "Cargó una página diferente al de home"); |
There was a problem hiding this comment.
I think is not necessary to validate the current URL of the site. What if changes?
|
|
||
| @BeforeTest | ||
| public void initSetup() { | ||
| spotifyUrl = propertyReader.getProperty("credentials.properties", "URL_WEBSITE"); |
There was a problem hiding this comment.
These values are not user credentials. Create a new properties file for these kinds of values
| @BeforeTest | ||
| public void initSetup() { | ||
| spotifyUrl = propertyReader.getProperty("credentials.properties", "URL_WEBSITE"); | ||
| helpUrl = propertyReader.getProperty("credentials.properties", "URL_HELP"); |
There was a problem hiding this comment.
Where are you using this variable?
| import org.testng.annotations.Test; | ||
|
|
||
| public class SpotifyIconTest extends BaseTest { | ||
| private String spotifyUrl, helpUrl; |
There was a problem hiding this comment.
Why these variables are global?
Agradeceré le den una revisada, estoy seguro que se pueden hacer mejoras, pero para efectos prácticos del ejercicio creo que se puede tomar por concluido salvo su mejor opinión.