Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crit damage is not calculated correctly #46

Closed
maurezen opened this issue Mar 28, 2019 · 1 comment
Closed

Crit damage is not calculated correctly #46

maurezen opened this issue Mar 28, 2019 · 1 comment

Comments

@maurezen
Copy link
Owner

At the moment it goes without any knowledge of MegaCrits. Should use getMegaCritDamageMult(critTier).
maurezen added a commit that referenced this issue Mar 28, 2019
@maurezen
#46 - crit damage is not calculated correctly
5ceaaed 
crit application function in battlecalc - megacrit-aware weighted crit multiplier
maurezen added a commit that referenced this issue Mar 28, 2019
@maurezen
#46 - crit damage is not calculated correctly
e518574 
using new function in automap
maurezen added a commit that referenced this issue Mar 28, 2019
@maurezen
#46 - crit damage is not calculated correctly
3739e08 
damn typos
maurezen added a commit that referenced this issue Mar 28, 2019
@maurezen
#46 - crit damage is not calculated correctly
90288ee 
fixed infinite cycle
(damn I need an IDE)
maurezen added a commit that referenced this issue Mar 28, 2019
@maurezen
#46 - crit damage is not calculated correctly
2e420b5 
megacrit modifier and application
@maurezen
Copy link
Owner Author

alright, it's still an order of magnitude off but the crit stuff is pretty much on point.
should probably do #7 next.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@maurezen