Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify mob health/dmg calculations #7

Open
maurezen opened this issue Nov 27, 2018 · 3 comments
Open

Unify mob health/dmg calculations #7

maurezen opened this issue Nov 27, 2018 · 3 comments

Comments

@maurezen
Copy link
Owner

No description provided.

@maurezen
Copy link
Owner Author

At a bare minimum, refactor everything to use a single point of calculation.

At a maximum, refactor to use game's calculation code.

@maurezen maurezen mentioned this issue Dec 30, 2018
Closed
@maurezen
Copy link
Owner Author

In the internals of stance/farming calculations in AutoStance2 baseDamage and baseHealth are about two orders of magnitude lesser than we actually have (observed when having an amalgamator on obliterated2, probably applies everywhere).

So, applies to trimps health/dmg as well.

maurezen added a commit that referenced this issue Jan 11, 2019
@maurezen
#7 - Unify mob health/dmg calculations - temporary helper solution
3d7166a
maurezen added a commit that referenced this issue Jan 11, 2019
@maurezen
#7 - Unify mob health/dmg calculations - temporary helper solution
5690e7a
maurezen added a commit that referenced this issue Jan 11, 2019
@maurezen
#7 - Unify mob health/dmg calculations - temporary helper solution
1b3e95b
@maurezen
Copy link
Owner Author

use function calculateDamage(number, buildString, isTrimp, noCheckAchieve, cell)
typical invocation calculateDamage(game.global.soldierCurrentAttack, false, true);
it gets an accurate pre-crit calculation in current stance, which we can then adjust for stance and crit

@maurezen maurezen mentioned this issue Mar 28, 2019
Closed
@maurezen maurezen mentioned this issue Sep 3, 2019
Closed
maurezen added a commit that referenced this issue Sep 4, 2019
@maurezen
#7 - Unify mob health/dmg calculations
8090a6a 
deferred trimp atk calculation in autostance 1 to base game's method
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@maurezen