Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support all string types in UCR #9

Merged
merged 2 commits into from
Apr 25, 2023
Merged

Support all string types in UCR #9

merged 2 commits into from
Apr 25, 2023

Conversation

felixdivo
Copy link
Collaborator

This works locally, but would need a test case before merging.

@felixdivo felixdivo marked this pull request as ready for review April 24, 2023 22:46
@felixdivo
Copy link
Collaborator Author

Test case was added in fe7c5ac

@mauricekraus mauricekraus merged commit 0a86417 into next Apr 25, 2023
3 checks passed
@felixdivo felixdivo deleted the felixdivo-patch-string-dtype-ucr branch April 25, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mauricekraus mauricekraus mauricekraus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@felixdivo @mauricekraus