Exposed tooltip longPress action when available (#117338)

* Exposed tooltip longPress action when available (Trigger mode is long press)
mauricioluz · Dec 20, 2022 · 38e3930 · 38e3930
1 parent 7f7a877
commit 38e3930
Show file tree

Hide file tree

Showing 9 changed files with 28 additions and 3 deletions.
diff --git a/packages/flutter/lib/src/material/tooltip.dart b/packages/flutter/lib/src/material/tooltip.dart
@@ -751,7 +751,7 @@ class TooltipState extends State<Tooltip> with SingleTickerProviderStateMixin {
         behavior: HitTestBehavior.opaque,
         onLongPress: (_triggerMode == TooltipTriggerMode.longPress) ? _handlePress : null,
         onTap: (_triggerMode == TooltipTriggerMode.tap) ? _handleTap : null,
-        excludeFromSemantics: true,
+        excludeFromSemantics: _excludeFromSemantics,
         child: result,
       );
       // Only check for hovering if there is a mouse connected.

diff --git a/packages/flutter/test/material/back_button_test.dart b/packages/flutter/test/material/back_button_test.dart
@@ -172,6 +172,7 @@ void main() {
       hasEnabledState: true,
       isEnabled: true,
       hasTapAction: true,
+      hasLongPressAction: true,
       isFocusable: true,
     ));
     handle.dispose();
@@ -216,6 +217,7 @@ void main() {
       hasEnabledState: true,
       isEnabled: true,
       hasTapAction: true,
+      hasLongPressAction: true,
       isFocusable: true,
     ));
     handle.dispose();

diff --git a/packages/flutter/test/material/calendar_date_picker_test.dart b/packages/flutter/test/material/calendar_date_picker_test.dart
@@ -672,6 +672,7 @@ void main() {
           tooltip: 'Previous month',
           isButton: true,
           hasTapAction: true,
+          hasLongPressAction: true,
           isEnabled: true,
           hasEnabledState: true,
           isFocusable: true,
@@ -680,6 +681,7 @@ void main() {
           tooltip: 'Next month',
           isButton: true,
           hasTapAction: true,
+          hasLongPressAction: true,
           isEnabled: true,
           hasEnabledState: true,
           isFocusable: true,

diff --git a/packages/flutter/test/material/chip_test.dart b/packages/flutter/test/material/chip_test.dart
@@ -2047,7 +2047,10 @@ void main() {
                             children: <TestSemantics>[
                               TestSemantics(
                                 tooltip: 'Delete',
-                                actions: <SemanticsAction>[SemanticsAction.tap],
+                                actions: <SemanticsAction>[
+                                  SemanticsAction.tap,
+                                  SemanticsAction.longPress
+                                ],
                                 textDirection: TextDirection.ltr,
                                 flags: <SemanticsFlag>[
                                   SemanticsFlag.isButton,

diff --git a/packages/flutter/test/material/date_picker_test.dart b/packages/flutter/test/material/date_picker_test.dart
@@ -833,6 +833,7 @@ void main() {
           tooltip: 'Switch to input',
           isButton: true,
           hasTapAction: true,
+          hasLongPressAction: true,
           isEnabled: true,
           hasEnabledState: true,
           isFocusable: true,
@@ -876,6 +877,7 @@ void main() {
           tooltip: 'Switch to calendar',
           isButton: true,
           hasTapAction: true,
+          hasLongPressAction: true,
           isEnabled: true,
           hasEnabledState: true,
           isFocusable: true,

diff --git a/packages/flutter/test/material/floating_action_button_test.dart b/packages/flutter/test/material/floating_action_button_test.dart
@@ -699,6 +699,7 @@ void main() {
                       tooltip: 'Add Photo',
                       actions: <SemanticsAction>[
                         SemanticsAction.tap,
+                        SemanticsAction.longPress,
                       ],
                       flags: <SemanticsFlag>[
                         SemanticsFlag.hasEnabledState,

diff --git a/packages/flutter/test/material/search_test.dart b/packages/flutter/test/material/search_test.dart
@@ -620,7 +620,10 @@ void main() {
                               SemanticsFlag.isEnabled,
                               SemanticsFlag.isFocusable,
                             ],
-                            actions: <SemanticsAction>[SemanticsAction.tap],
+                            actions: <SemanticsAction>[
+                              SemanticsAction.tap,
+                              SemanticsAction.longPress,
+                            ],
                             tooltip: 'Back',
                             textDirection: TextDirection.ltr,
                           ),

diff --git a/packages/flutter/test/material/tooltip_test.dart b/packages/flutter/test/material/tooltip_test.dart
@@ -1450,6 +1450,9 @@ void main() {
           id: 1,
           tooltip: 'TIP',
           textDirection: TextDirection.ltr,
+          actions: <SemanticsAction>[
+            SemanticsAction.longPress,
+          ],
         ),
       ],
     );
@@ -1650,6 +1653,9 @@ void main() {
                       tooltip: 'Foo',
                       label: 'Bar',
                       textDirection: TextDirection.ltr,
+                      actions: <SemanticsAction>[
+                        SemanticsAction.longPress,
+                      ],
                     ),
                   ],
                 ),

diff --git a/packages/flutter/test/material/tooltip_theme_test.dart b/packages/flutter/test/material/tooltip_theme_test.dart
@@ -1105,6 +1105,9 @@ void main() {
                       tooltip: 'Foo',
                       label: 'Bar',
                       textDirection: TextDirection.ltr,
+                      actions: <SemanticsAction>[
+                        SemanticsAction.longPress,
+                      ],
                     ),
                   ],
                 ),
@@ -1148,6 +1151,9 @@ void main() {
                       tooltip: 'Foo',
                       label: 'Bar',
                       textDirection: TextDirection.ltr,
+                      actions: <SemanticsAction>[
+                        SemanticsAction.longPress,
+                      ],
                     ),
                   ],
                 ),