working workflow, individually check for the existence of secrets #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Testing for secrets individually
|
lgtm, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi it's me again. I modified the workflow to check for the existence of the required secrets (
CHROMATIC_PROJECT_TOKENandFOSSA_API_KEY), so that these steps don't run when no token is configured. This way it makes much more sense than just disabling the workflow for pull requests, since then forked repos would have had to add their tokens or have the workflow immediately fail.This is meant to be a drop-in replacement, since the secrets are already configured. Basically just 'merge/rebase' and that's it.
PS: The solution to testing for secrets is a bit hacky, github actions doesn't have anything nicer.
PS2: The
fetch-depth: 0can be removed, we don't need the entire repo (currently it takes a whole minute to download the repo). We only need the latest code (commit).