Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for multiple environments (external configuration keycloak.json i.e env. promotion) #35

Closed
aelkz opened this issue Mar 26, 2018 · 2 comments
Labels
enhancement This issue/PR is an enhancement or new feature.

Comments

@aelkz
Copy link
Contributor

aelkz commented Mar 26, 2018

Hello @mauriciovigolo ,

IHAC that needed a NPM module to integrate with angular apps. So I've started designing my own keycloak module last year and we had some improvements in terms of environment promotion using CI (jenkins).

With this feature, we can be able to externalize the keycloak configurations and easy integrate with a pre-built jenkins job to grab all configurations needed for a specific enviroment. Today we are working with local (development), test, pre-production and production.

The initial params are:
realm, auth-server-url, welcome-url, client-id, and so on..

// for example, allow the following:
$ ng build --env=prod

So, instead of publishing my project on github, I thought of sharing with you some ideas and contribute to this project.

@mauriciovigolo
Copy link
Owner

Hi @aelkz,

All the help is welcome! I just included a link at the readme to get an invite to the keycloak-angular chat on slack. We can talk more there about your ideas, but leave this issue open until we define what to do.

Thank you for your help and interest in this library!

@mauriciovigolo mauriciovigolo added the enhancement This issue/PR is an enhancement or new feature. label Apr 3, 2018
@aelkz
Copy link
Contributor Author

aelkz commented Apr 12, 2018

Hello, @mauriciovigolo after doing some analysis into the project I realized that it already handles the keycloak.json and init parameters. So, for the moment, I don't see any additional configurations that we could be adding for now. I'll keep looking for improvements and closing this issue. Thanks!

@aelkz aelkz closed this as completed Apr 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This issue/PR is an enhancement or new feature.
Projects
None yet
Development

No branches or pull requests

2 participants