Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Angular 6 #51

Closed
samherrmann opened this issue May 4, 2018 · 3 comments
Closed

Add support for Angular 6 #51

samherrmann opened this issue May 4, 2018 · 3 comments
Assignees
Labels
bug This issue/PR is a bug.

Comments

@samherrmann
Copy link

Environment:

  • keycloak-angular 1.3.0
  • Angular 6.0.0
  • RxJs 6.1.0

Description:
RxJs 6, included in Angular 6, has a few breaking changes one of which is a change in import paths.
When importing keycloak in an Angular 6 project, the following compile errors are thrown:

ERROR in node_modules/keycloak-angular/src/services/keycloak.service.d.ts(2,10): error TS2305: Module '"/code/node_modules/rxjs/Observable"' has no exported member 'Observable'.
node_modules/rxjs/Observable.d.ts(1,15): error TS2307: Cannot find module 'rxjs-compat/Observable'.

The error can be patched with npm install rxjs-compat during the migration period.

This Issue is a request to support rxjs v6 without needing to install the rxjs-compat module.

@mauriciovigolo
Copy link
Owner

@samherrmann thanks for opening the issue!

I'm working on the next version of the library and I'm expecting to release it on this weekend to be compatible with angular 6.

I'm planning a new versioning strategy and i'm testing some possibilities, however I will probably follow the angular major version, for example:

  • keycloak-angular 6.x.x will be compatible with angular 6
  • keycloak-angular 5.x.x will be compatible with angular 5
  • keycloak-angular 4.x.x will be compatible with angular 4

I think that delivering the lib in this way will be easier to maintain the angular compatibility and also, easier for the developer choose the right version.

Right now I'm thinking the best way to deal with the keycloak-js lib version and making some experiments.

@mauriciovigolo mauriciovigolo added the bug This issue/PR is a bug. label May 5, 2018
@mauriciovigolo mauriciovigolo self-assigned this May 5, 2018
@mauriciovigolo mauriciovigolo added this to the v.6.0.0 milestone May 6, 2018
@aelkz
Copy link
Contributor

aelkz commented May 6, 2018

I agree! cheers

@mauriciovigolo mauriciovigolo changed the title Add support for RxJs 6 Add support for Angular 6 May 12, 2018
@mauriciovigolo mauriciovigolo moved this from To Do to In progress in keycloak-angular v. 4.0.0 May 18, 2018
@kashpatel
Copy link

I was just going to open new issue for this but just noticed this one. Looking forward to v6 over the weekend.
Thanks for the library and keep up the good work.

mauriciovigolo added a commit that referenced this issue May 21, 2018
- This commit includes the work done in milestone v.4.0.0.
- Milestone v.4.0.0 includes the following issues:
#47, #50, #51, #52, #56, #58 and #61
@mauriciovigolo mauriciovigolo moved this from In progress to Done in keycloak-angular v. 4.0.0 May 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR is a bug.
Projects
No open projects
Development

No branches or pull requests

4 participants