Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: only add token to header if user is logged in #164

Merged
merged 1 commit into from Oct 9, 2019
Merged

feat: only add token to header if user is logged in #164

merged 1 commit into from Oct 9, 2019

Conversation

Mawi137
Copy link
Contributor

@Mawi137 Mawi137 commented Oct 8, 2019

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

The user is forced to login when the interceptor is called.

Issue Number: #162

What is the new behavior?

The token is only added if the user is actually logged in.
This allows endpoints to be called anonymously.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

- The interceptor will only add the token if the user is logged in and will no longer force the user to login

Fixes #162
@mauriciovigolo
Copy link
Owner

Thank you @Mawi137! I will merge and publish it in v7.1.0.

@mauriciovigolo mauriciovigolo merged commit c24ae4e into mauriciovigolo:master Oct 9, 2019
@mauriciovigolo mauriciovigolo added Status: Accepted enhancement This issue/PR is an enhancement or new feature. labels Oct 9, 2019
@mauriciovigolo mauriciovigolo added this to the 7.1.0 milestone Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This issue/PR is an enhancement or new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants