This repository has been archived by the owner on Feb 7, 2019. It is now read-only.
Change from Winston to PyPlot for plotting #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obiajulu
force-pushed
the
ob/pyplot2
branch
3 times, most recently
from
fa576e1
to
c7d957b
Compare
|
Not sure how far along this is, so some comments maybe unnecessary:
|
|
I made more changes and I think it are closer to being mergable. |
| @@ -22,6 +22,7 @@ solver = S.allsolvers[[ODE.ode78, | |||
| # make a TestRun which combines a TestCase with a Solver + some extras: | |||
| ##Example protocol For adaptive solvers | |||
| abstol = 1e-12 | |||
|
|
|||
There was a problem hiding this comment.
Revert this. (Try not to have unrelated changes in your PRs)
mauro3
force-pushed
the
ob/pyplot2
branch
3 times, most recently
from
f1b0e9f
to
4efbb47
Compare
|
I tested it and did some extra changes. Maybe you can test and review it. If happy merge. |
A larger commit, which constitutes the move from Winston to PyPlot for ploting.
|
Cool, tnx @obiajulu! |
| maxscd = max(maxscd, maximum(scd)) | ||
| wt = getfield_vec(res, :walltime) | ||
| @show cols[rem1(colind,nc)] | ||
| p = Py.plot(scd, wt, "-d"*cols[rem1(colind,nc)]) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch in package for handling plotting.