Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed typo #6

Closed
wants to merge 1 commit into from
Closed

Fixed typo #6

wants to merge 1 commit into from

Conversation

lolzone13
Copy link

@lolzone13 lolzone13 commented Jun 19, 2022

What type of PR is this? (check all applicable)

  • Enhancement
  • Refactor
  • [ . ] Bug Fix
  • Feature
  • Documentation Update

What I did

Changed "i'm" to "I'm" in src/resources/templates.ts

Fixes issue #4

@vercel
Copy link

vercel bot commented Jun 19, 2022

Someone is attempting to deploy a commit to a Personal Account owned by @maurodesouza on Vercel.

@maurodesouza first needs to authorize it.

@maurodesouza
Copy link
Owner

Hi @lolzone13 👋

I am very grateful that you contributed to the project ❤ but your commit is not following the style guide, and also, the issue #4 already had a assigned, he made a PR with a fix before you (#5), so I considered his fix.

About the style guide for commit, you can find it here.

❌ Closed PR

Reasons:

  1. Commit not following style guide.
  • Commit subject without type;
  • Commit subject without emoji;
  • Commit subject is not all lowercase.
  1. Issue already had a assigned.

@lolzone13 lolzone13 deleted the fix/typo-bug branch June 22, 2022 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants