Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix character case in headline #5

Closed
wants to merge 2 commits into from
Closed

Fix character case in headline #5

wants to merge 2 commits into from

Conversation

CassioLeodegario
Copy link
Contributor

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Enhancement
  • Documentation Update

What I did

  • Fix small typo in how the word "I' was being used

@vercel
Copy link

vercel bot commented Jun 19, 2022

Someone is attempting to deploy a commit to a Personal Account owned by @maurodesouza on Vercel.

@maurodesouza first needs to authorize it.

@maurodesouza
Copy link
Owner

Hi @CassioLeodegario 👋

I am very grateful that you contributed to the project ❤ but your commit is not following the style guide, please consider create a new branch, redoing your commit and opening a new PR.

Suggestions:

  • Commit:
🐛 fix: spelling mistake

Close #5

By writing Close #{Issue number} in the commit footer, the PR will automatically link to the issue and close it when the PR is merged 🤖

  • Branch: fix/spelling-mistake

About the style guide for commit, you can find it here.

About the guide for PR, you cand find it here.

❌ Closed PR

Reasons:

  1. Commit not following style guide.
  • Commit subject without type;
  • Commit subject without emoji related to type;
  • Commit subject is not all lowercase;
  1. PR not following the guide.
  • No branch created.

CassioLeodegario added a commit to CassioLeodegario/profile-readme-generator that referenced this pull request Jun 20, 2022
Fixing a small spelling for the word "I" 

Close maurodesouza#5
@CassioLeodegario
Copy link
Contributor Author

CassioLeodegario commented Jun 20, 2022

Hi, @maurodesouza

Thanks for your feedback and sorry for not looking for the CONTRIBUTING.md file

I'm adressing a new PR right now, I hope to be compliant this time 😁

@CassioLeodegario CassioLeodegario mentioned this pull request Jun 20, 2022
5 tasks
@maurodesouza maurodesouza mentioned this pull request Jun 22, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants