Migrate plugins from M4 to M5 #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shinde-rahul
approved these changes
Apr 24, 2024
RCheesley
requested changes
Apr 26, 2024
There was a problem hiding this comment.
Thanks for this super useful guide @escopecz - I've suggested some changes to fix the remaining Vale errors and a few general style suggestions.
We don't normally use numbers in headings so I've recommended removing them, but you'll need to also shorten the underline accordingly. I'll commit the link file directly to the PR so you don't need to generate it yourself.
Co-authored-by: Ruth Cheesley <ruth@ruthcheesley.co.uk>
Co-authored-by: Ruth Cheesley <ruth@ruthcheesley.co.uk>
wording improvements Co-authored-by: Ruth Cheesley <ruth@ruthcheesley.co.uk>
Link improvements Co-authored-by: Ruth Cheesley <ruth@ruthcheesley.co.uk>
Removing ordered list from headings Co-authored-by: Ruth Cheesley <ruth@ruthcheesley.co.uk>
Formating fixes Co-authored-by: Ruth Cheesley <ruth@ruthcheesley.co.uk>
Typo fixes Co-authored-by: Ruth Cheesley <ruth@ruthcheesley.co.uk>
RCheesley
requested changes
Apr 26, 2024
RCheesley
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting a list of steps that are needed to upgrade a plugin from Mautic 4 to 5. Each of the mentioned steps got me stuck for hours and I also got myself confused by using different order of the steps or running slightly incomplete commands. So hopefully this will help others and future me.