Fix PHPStan

mautic · Mar 21, 2022 · c2c4042 · c2c4042
1 parent 186c4cd
commit c2c4042
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 11 deletions.
diff --git a/app/bundles/LeadBundle/Event/ListChangeEvent.php b/app/bundles/LeadBundle/Event/ListChangeEvent.php
@@ -44,21 +44,21 @@ public function getLead()
     }
 
     /**
-     * Returns batch array of leads.
-     *
-     * @return array
+     * @return LeadList
      */
-    public function getLeads()
+    public function getList()
     {
-        return $this->leads;
+        return $this->list;
     }
 
     /**
-     * @return LeadList
+     * Returns batch array of leads.
+     *
+     * @return array|null
      */
-    public function getList()
+    public function getLeads()
     {
-        return $this->list;
+        return $this->leads;
     }
 
     /**

diff --git a/app/bundles/LeadBundle/EventListener/WebhookSubscriber.php b/app/bundles/LeadBundle/EventListener/WebhookSubscriber.php
@@ -262,7 +262,7 @@ public function onCompanyDelete(CompanyEvent $event)
         );
     }
 
-    public function onSegmentChange(ListChangeEvent $changeEvent)
+    public function onSegmentChange(ListChangeEvent $changeEvent): void
     {
         $contacts = null !== $changeEvent->getLeads() ? $changeEvent->getLeads() : [$changeEvent->getLead()];
         foreach ($contacts as $contact) {

diff --git a/app/bundles/LeadBundle/Tests/EventListener/WebhookSubscriberTest.php b/app/bundles/LeadBundle/Tests/EventListener/WebhookSubscriberTest.php
@@ -15,11 +15,12 @@
 use Mautic\LeadBundle\LeadEvents;
 use Mautic\WebhookBundle\Model\WebhookModel;
 use Symfony\Component\EventDispatcher\EventDispatcher;
+use Symfony\Component\EventDispatcher\EventDispatcherInterface;
 
 class WebhookSubscriberTest extends \PHPUnit\Framework\TestCase
 {
     /**
-     * @var EventDispatcher|MockObject
+     * @var EventDispatcherInterface
      */
     private $dispatcher;
 
@@ -188,7 +189,7 @@ public function testOnCompanySaveAndDelete()
         $dispatcher->dispatch(LeadEvents::COMPANY_POST_DELETE, $event);
     }
 
-    public function testOnSegmentChange()
+    public function testOnSegmentChange(): void
     {
         $mockModel  = $this->createMock(WebhookModel::class);