Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GoTo Webinar Segments filters are broken #11577

Closed
1 task done
dsp76 opened this issue Oct 12, 2022 · 6 comments
Closed
1 task done

GoTo Webinar Segments filters are broken #11577

dsp76 opened this issue Oct 12, 2022 · 6 comments
Labels
bug Issues or PR's relating to bugs plugin Anything related to plugins segments Anything related to segments stale Issues which have not received an update within 90 days

Comments

@dsp76
Copy link

dsp76 commented Oct 12, 2022

Mautic Version

4.4.x series

PHP version

7.4.x

What browsers are you seeing the problem on?

No response

What happened?

Segment filters for webinar fields load without values.

image

Only after saving the segment without selection first, the selection fields show up.

image

However - looks like this fix isn't working anymore:
#9251 @kuzmany

Webinars will again be shown with the wrong descriptions.

How can we reproduce this issue?

Step 1: Create a new segment in Mautic 4.4.3
Step 2: Define a filter related to webinars
Step 3: Look at the provided values to choose from

Relevant log output

No response

Code of Conduct

  • I confirm that I have read and agree to follow this project's Code of Conduct
@dsp76 dsp76 added bug Issues or PR's relating to bugs needs-triage For new issues/PRs that need to be triaged labels Oct 12, 2022
@dsp76
Copy link
Author

dsp76 commented Oct 12, 2022

I tested to reverse the flip array removal (#9251) in the mautic/plugins/MauticCitrixBundle/EventListener/LeadSubscriber.php ...

Compared to the referred PR, there were only two occasions of this (were 4 changes in 9251). It seems to have fixed the "Webinar (registered)" and "Webinar (attended)" filter, but not the "Webinar (did not attend)". There we see the cryptic descriptions (non flipped).

So only a partly success and also I have no clue, why this is now needed again.

The save before you can filter issue is also not solved by that (didn't expect it either).

@RCheesley
Copy link
Sponsor Member

Thanks for flagging this up @dsp76 - there were indeed some issues with the filter fields but I thought this was all fixed. Maybe something has been lost from that fix in the current code base, I know we had a lot of conflicts to resolve a while ago so that could be the case. @kuzmany @escopecz would one of you be able to take a look and see if something has gone awry somewhere in the release/merge process please? Thanks!

@RCheesley RCheesley added plugin Anything related to plugins segments Anything related to segments and removed needs-triage For new issues/PRs that need to be triaged labels Oct 21, 2022
@escopecz
Copy link
Sponsor Member

@kuzmany can you please re-test the changes you made in #9251? It looks like it caused a regression.

@stale
Copy link

stale bot commented Jan 21, 2023

This issue or PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you would like to keep it open please let us know by replying and confirming that this is still relevant to the latest version of Mautic and we will try to get to it as soon as we can. Thank you for your contributions.

@stale stale bot added the stale Issues which have not received an update within 90 days label Jan 21, 2023
@stale
Copy link

stale bot commented Feb 4, 2023

This issue or PR has been automatically closed because it has not had recent activity. In the case of issues, if it persists in the latest version of Mautic, please create a new issue and link back to this one for reference. With PRs if you wish to pick up the PR and update it so that it can be considered for a future release, please comment and we will re-open it. Thank you for your contributions.

@stale stale bot closed this as completed Feb 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2023

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If this issue is continuing with the lastest stable version of Mautic, please open a new issue that references this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues or PR's relating to bugs plugin Anything related to plugins segments Anything related to segments stale Issues which have not received an update within 90 days
Projects
None yet
Development

No branches or pull requests

3 participants