Fix Citrix segment filter

[kuzmany]

Q	A
Branch?	staging for features or enhancements / 3.0 for bug fixes
Bug fix?	yes/no
New feature?	yes/no
Deprecations?	yes/no
BC breaks?	yes/no
Automated tests included?	yes/no
Related user documentation PR URL	mautic/mautic-documentation#...
Related developer documentation PR URL	mautic/developer-documentation#...
Issue(s) addressed	Fixes #...

Description:

Segment filters for Citrix services are wrong in M3 due array_flip changes. This PR fixed it

Steps to test this PR:

1. Load up this PR
2. Setup Citrix plugin and Go To Webinar https://docs.mautic.org/en/plugins/citrix
3. Sync data php bin/console mautic:citrix:sync
4. Go to segment and try Webinars segment filter
5. Without fix you see wrong filters, after fix are correct

Before:

After

[npracht]

@flossels, @ekkeguembel, @luguenth can you please have a look at this with your experience on GoTo, that would be highly appreciated.
Thanks !

[codecov]

Codecov Report

Merging #9251 (c8af96b) into staging (8d5c970) will not change coverage.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             staging    #9251   +/-   ##
==========================================
  Coverage      31.17%   31.17%           
  Complexity     33546    33546           
==========================================
  Files           1943     1943           
  Lines         116002   116002           
==========================================
  Hits           36162    36162           
  Misses         79840    79840           

Impacted Files	Coverage Δ	Complexity Δ
...auticCitrixBundle/EventListener/LeadSubscriber.php	0.00% <0.00%> (ø)	35.00 <0.00> (ø)

[luguenth]

Works fine for me 👍

The base branch was changed.

[RCheesley]

I think this is good to go based on @luguenth 's +1 as it's a simple change we have made in many other places since 3.0. Just updated the base branch to staging, will need to check whether a rebase is required.

[RCheesley]

👍 based on the earlier reviews

[mautibot]

This pull request has been mentioned on Mautic Community Forums. There might be relevant details there:

https://forum.mautic.org/t/mautic-3-2-growing-together/17244/1

[dsp76]

Could it be, that this PR somehow is not in version 4.4.3 anymore? We upgraded a client and experiencing exactly the issue mentioned before the PR. However, shouldn't this PR now be merged also in version 4?

[RCheesley]

@dsp76 please raise a new issue if the problem has recurred - you can reference this PR if it previously fixed the issue! Thanks!