Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mailjet puts only ":" in lead_donotcontact.comment (after softbounces) #11888

Closed
1 task done
beetofly opened this issue Jan 20, 2023 · 7 comments
Closed
1 task done
Labels
bug Issues or PR's relating to bugs email-integrations Anything related to integrations with mail providers. Plugins have a separate label! ready-to-test PR's that are ready to test

Comments

@beetofly
Copy link
Contributor

beetofly commented Jan 20, 2023

Mautic Version

4.4.x series

PHP version

7.4.3

What browsers are you seeing the problem on?

Not relevant

What happened?

Problem in Mautic instances with mailjet:

Mautic process the callback response of mailjet for softbounced emails currently so, that in the database field comment in the table lead_donotcontact only a colon appears / is persisted.

How can we reproduce this issue?

Step 1:

In a Mautic instance with mailjet send an email, for example, to a "softbounce simulator" or an email account, which you configured as "full".

Step 2:

Wait until the response of mailjet for the softbounced email is back [Important: That can take up to three days (see also mailjet api documentation), because mailjet retries to send a softbounced email several times until the email will set to the status "softbounced" in mailjet and the callback to mautic will happen]

Step 3:

Open the table lead_donotcontact in the mautic database and you will see, that there is only a colon in the comment field of the softbounced email.

Relevant log output

No response

Code of Conduct

  • I confirm that I have read and agree to follow this project's Code of Conduct

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@beetofly beetofly added bug Issues or PR's relating to bugs needs-triage For new issues/PRs that need to be triaged labels Jan 20, 2023
@beetofly
Copy link
Contributor Author

I have already analysed the problem and will soon make a proposal to solve this problem via a pull request for this issue.

Reason of this problem:

So far Mautic uses the mailjet data fields error_related_to : error.
The JSON mailjet response for these both data fields are currently empty for softbounced emails.
But in the JSON mailjet response are the additional fields "hard_bounce" (bool) and "comment" (text) included, which are currently ignored by mautic.

So a possible solution for this problem:

I will include all relevant mailjet fields, so the "comment" field in "lead_donotcontact" will be
HARD : error_related_to : error : comment (if value of hard_bounce in JSON-Response of mailjet is true)
and
SOFT : error_related_to : error : comment (if value of hard_bounce in JSON-Response of mailjet is false)

My pull request with the code changes that implements this solution proposal in mautic will appear shortly.

@Moongazer
Copy link
Contributor

I think @Leuchtfeuer is already working on this

@jos0405 jos0405 added email-integrations Anything related to integrations with mail providers. Plugins have a separate label! and removed needs-triage For new issues/PRs that need to be triaged labels Feb 3, 2023
@escopecz escopecz added the ready-to-test PR's that are ready to test label Mar 28, 2023
escopecz added a commit that referenced this issue Jul 24, 2023
Fixes #11888 for mailjet puts only : in lead_donotcontact.comment
@stale
Copy link

stale bot commented Sep 16, 2023

This issue or PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you would like to keep it open please let us know by replying and confirming that this is still relevant to the latest version of Mautic and we will try to get to it as soon as we can. Thank you for your contributions.

@stale stale bot added the stale Issues which have not received an update within 90 days label Sep 16, 2023
@RCheesley
Copy link
Sponsor Member

@ekkeguembel are your team working on this?

@stale stale bot removed the stale Issues which have not received an update within 90 days label Sep 22, 2023
@beetofly
Copy link
Contributor Author

@RCheesley PR for that issue is merged in 4.4.10

@beetofly
Copy link
Contributor Author

Fixed for mautic 4 via PR Fixes #11888 for mailjet puts only : in lead_donotcontact.comment #11912 (in release 4.4.10)

@github-actions
Copy link
Contributor

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If this issue is continuing with the lastest stable version of Mautic, please open a new issue that references this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues or PR's relating to bugs email-integrations Anything related to integrations with mail providers. Plugins have a separate label! ready-to-test PR's that are ready to test
Projects
Archived in project
Development

No branches or pull requests

5 participants