Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Payload data is nested by extra layer #5119

Closed
atomdmac opened this issue Oct 9, 2017 · 4 comments
Closed

Payload data is nested by extra layer #5119

atomdmac opened this issue Oct 9, 2017 · 4 comments
Labels
bug Issues or PR's relating to bugs ready-to-test PR's that are ready to test
Milestone

Comments

@atomdmac
Copy link

atomdmac commented Oct 9, 2017

What type of report is this:

Q A
Bug report? X
Feature request?
Enhancement?

Description:

Somewhere between version 2.8.2 and 2.9.1 the mautic.lead_post_save_update test webhook payload seems to have changed to introduce an additional layer of mautic.lead_post_save_update

-I'm not currently sure if this applies to test payloads and normal "production" payloads or not. I've only tested it with the Send Test Payload button at this point.-

This appears to be an issue with the test payloads (sent from Settings > Webhooks > [Webhook] > Edit > Send Test Payload). Normal payloads (so far) seem to unaffected.

As of 2.8.2

{ 'mautic.lead_post_save_update':
   { lead:
      { ...lead data here },
  timestamp: '2017-10-09T11:07:44-04:00' }

As of 2.9.1

{ 'mautic.lead_post_save_update':
   { 'mautic.lead_post_save_update':
      [ { lead:
           { ...lead data here} ] },
  timestamp: '2017-10-09T15:11:28+00:00' }

If a bug:

Q A
Mautic version 2.9.1
PHP version 7.0.18-0ubuntu0.16.04.1

Steps to reproduce:

  1. Create a new 'Contact Updated Event' webhook
  2. Send a test payload
  3. Notice that there is an extra layer of mautic.lead_post_save_update

Log errors:

None that I was able to find in the system settings > logs area.

@atomdmac
Copy link
Author

atomdmac commented Oct 11, 2017

Update: This still exists in 2.10.1.

@dbhurley dbhurley added the bug Issues or PR's relating to bugs label Jan 21, 2018
@escopecz
Copy link
Sponsor Member

Cannot replicate. Can you please confirm it's still an issue?

@escopecz escopecz added the pending-feedback PR's and issues that are awaiting feedback from the author label Oct 23, 2018
@Clement134
Copy link
Contributor

This issue still exists in 2.15.0-dev.

Event name is automatically added on test payload, but it was also present in the fake payload for some lead events (lead_post_save_new for example).

It should be fixed with #6948.

@escopecz escopecz added ready-to-test PR's that are ready to test and removed pending-feedback PR's and issues that are awaiting feedback from the author labels Dec 3, 2018
@npracht
Copy link
Member

npracht commented Apr 12, 2019

Fixed by #6948 merged in 2.15.1

@npracht npracht closed this as completed Apr 12, 2019
@npracht npracht added this to the 2.15.1 milestone Apr 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues or PR's relating to bugs ready-to-test PR's that are ready to test
Projects
None yet
Development

No branches or pull requests

5 participants