Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix test payloads for lead webhooks #6948

Merged
merged 1 commit into from Jan 30, 2019
Merged

fix test payloads for lead webhooks #6948

merged 1 commit into from Jan 30, 2019

Conversation

Clement134
Copy link
Contributor

Q A
Bug fix? Yes
New feature? No
Automated tests included? No
Related user documentation PR URL No
Related developer documentation PR URL No
Issues addressed (#s or URLs) #5119
BC breaks? No
Deprecations? No

Description:

Like explained in #5119 event name is present twice in webhook test payload. This doesn't reflect the real payload sent on this events.

Steps to reproduce the bug:

  1. Create a new webhook for leads events
  2. Click on "Send test payload"
  3. Each event name will appear twice in the payload

Steps to test this PR:

  1. Create a new webhook for leads events
  2. Click on "Send test payload"
  3. Each event name will appear only once

@Clement134 Clement134 mentioned this pull request Dec 2, 2018
Closed
@escopecz escopecz added bug Issues or PR's relating to bugs ready-to-test PR's that are ready to test code-review-needed PR's that require a code review before merging labels Dec 3, 2018
@npracht npracht modified the milestone: 2.15.1 Dec 3, 2018
@heathdutton heathdutton added this to Code Review (2 required) in Mautic 2 Dec 6, 2018
@alanhartless alanhartless added this to Needs Testing in 2.15.1 Jan 14, 2019
Mautic 2 automation moved this from Code Review (2 required) to Ready to Test (first time) Jan 30, 2019
@alanhartless alanhartless merged commit 66e0561 into mautic:staging Jan 30, 2019
Mautic 2 automation moved this from Ready to Test (first time) to Merged Jan 30, 2019
@alanhartless alanhartless moved this from Needs Testing to Merged in 2.15.1 Jan 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanhartless alanhartless alanhartless approved these changes

Assignees
No one assigned
Labels
bug Issues or PR's relating to bugs code-review-needed PR's that require a code review before merging ready-to-test PR's that are ready to test
Projects
No open projects
2.15.1
Merged
Milestone
2.15.1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Clement134 @alanhartless @escopecz @npracht