Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

company select fields in forms do not update #5733

Closed
johbuch opened this issue Feb 21, 2018 · 12 comments
Closed

company select fields in forms do not update #5733

johbuch opened this issue Feb 21, 2018 · 12 comments
Labels
bug Issues or PR's relating to bugs ready-to-test PR's that are ready to test
Milestone
2.14.0

Comments

@johbuch
Copy link
Contributor

johbuch commented Feb 21, 2018

Please DO NOT report security vulnerabilities here. Send them to security@mautic.com instead.

What type of report is this:

Q A
Bug report? X
Feature request?
Enhancement?

Description:

I submit a form with a select company field, but the value does not update when I check the company sheet.

If a bug:

Q A
Mautic version 2.12.2
PHP version

Steps to reproduce:

  1. Create a select company field custom field with some values
    image
  2. Create a form, add contact email, contact company field and the company custom field previously created.
    image
  3. Submit the form
  4. Go check the company sheet that has been created (or updated with this new select custom field).
  5. Company has been created but this field is still empty.
  6. See my form result below
    image
  7. See my company field below (empty)
    image

Log errors:

Please check for related errors in the latest log file in [mautic root]/app/log/ and/or the web server's logs and post them here. Be sure to remove sensitive information if applicable.
@npracht
Copy link
Member

npracht commented Feb 21, 2018

Label: Bug

@mautibot mautibot added the bug Issues or PR's relating to bugs label Feb 21, 2018
@mburamorde
Copy link

I can confirm this bug. Maybe there are parallels with #5499

@kuzmany
Copy link
Member

kuzmany commented Feb 27, 2018

@mburamorde Did you try #5611 ? Can you confirmed this issue after apply that PR?

@kuzmany
Copy link
Member

kuzmany commented Feb 27, 2018 •
edited

Label: WIP

@mautibot mautibot added the WIP PR's that are not ready for review and are currently in progress label Feb 27, 2018
@kuzmany
Copy link
Member

kuzmany commented Feb 27, 2018 •
edited

This not resolve it? #5567 (released in 2.12.2)

@mautibot mautibot removed the WIP PR's that are not ready for review and are currently in progress label Feb 27, 2018
@kuzmany
Copy link
Member

kuzmany commented Feb 27, 2018

Label: Pending Feedback

@mautibot mautibot added the pending-feedback PR's and issues that are awaiting feedback from the author label Feb 27, 2018
@npracht
Copy link
Member

npracht commented Mar 12, 2018

@kuzmany it is not correcting the issue.

  • The PR solves the fact of displaying the fields values.
  • The issue is about saving the selected value on the company field.

@npracht
Copy link
Member

npracht commented Mar 12, 2018

Label: Pending feedback

@mautibot mautibot removed the pending-feedback PR's and issues that are awaiting feedback from the author label Mar 12, 2018
@kuzmany
Copy link
Member

kuzmany commented Mar 12, 2018

Label: WIP

@mautibot mautibot added the WIP PR's that are not ready for review and are currently in progress label Mar 12, 2018
@kuzmany kuzmany mentioned this issue Apr 7, 2018
Merged
@kuzmany
Copy link
Member

kuzmany commented Apr 7, 2018 •
edited

Hope this fixed it #5915
Please test
Label: Ready to test

@mautibot mautibot added ready-to-test PR's that are ready to test and removed WIP PR's that are not ready for review and are currently in progress labels Apr 7, 2018
@johbuch
Copy link
Contributor Author

johbuch commented Apr 9, 2018

just tested PR #5915 it didn't work for me

@npracht
Copy link
Member

npracht commented Jun 3, 2018

Fixed in #5915 and merged

@npracht npracht closed this as completed Jun 3, 2018
@npracht npracht added this to the 2.14.0 milestone Jun 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Issues or PR's relating to bugs ready-to-test PR's that are ready to test
Projects
None yet
Milestone
2.14.0
Development

No branches or pull requests
5 participants
@kuzmany @mburamorde @mautibot @npracht @johbuch