Support for company fields in tracking code pageview event

[kuzmany]

Q	A
Bug fix?	y
New feature?
Automated tests included?
Related user documentation PR URL	mautic/documentation#266
Related developer documentation PR URL
Issues addressed (#s or URLs)	#5499
BC breaks?
Deprecations?

Description:

Added support for company fields in mt('send', 'pageview');
Inspirated by SubmissionModel

mautic/app/bundles/FormBundle/Model/SubmissionModel.php

Line 1017 in fed5d81

$companyFieldMatches = $getCompanyData($leadFieldMatches);

This PR also added more priority to companyname fields like take companyname from companyemail.

https://github.com/kuzmany/mautic/blob/1c1b1822aef2bec3f9ddebe0df8b7e0d7204569e/app/bundles/LeadBundle/Helper/IdentifyCompanyHelper.php#L76

Steps to reproduce the bug:

1. Mark company fields as Publicly updatable
2. Use
   mt('send', 'pageview', {companyemail: 'mycompany@mycompany.com', companywebsite: 'https://mautic.com/'});

More in docs https://mautic.org/docs/en/contacts/contact_monitoring.html (part Tracking of custom parameters)

3. See fields wasn't update in tracking contact

Steps to test this PR:

1. Repeat alls teps
2. See company fields was updated in Mautic

[npracht]

/label feature request

[npracht]

/label ready to test

[escopecz]

I'm getting Type error: Argument 1 passed to Mautic\LeadBundle\Model\CompanyModel::setFieldValues() must be an instance of Mautic\LeadBundle\Entity\Company, null given on this line.

[kuzmany]

Got it, fixed.

[escopecz]

It works for me now. 👍

Well, the tracking code must contain a companyname value to create a company and assign it to the contact. So this requirement must be documented.

[Maxell92]

Works for me. Could be merged after documentation is added.

[kuzmany]

@escopecz
As I read from source code https://github.com/kuzmany/mautic/blob/1c1b1822aef2bec3f9ddebe0df8b7e0d7204569e/app/bundles/LeadBundle/Helper/IdentifyCompanyHelper.php#L74

Mautic try find company name from
company
companyname
if not exist from domain name of email/company email
or if not exist domain name of companywebsite

This is right workflow?

[kuzmany]

@escopecz maybe we can remove email from findCompany https://github.com/kuzmany/mautic/blob/1c1b1822aef2bec3f9ddebe0df8b7e0d7204569e/app/bundles/LeadBundle/Helper/IdentifyCompanyHelper.php#L74

A lot of people use personal email like gmail, outlook, yahoo, seznam.cz and nobody from them work in that companies :)

[kuzmany]

@Maxell92 documentation added mautic/documentation#266

[escopecz]

Removing email domain from that code would be a business decision. Lets have it as is for now.

What I was noting is that if you use the sample code you provided:
mt('send', 'pageview', {companyemail: 'mycompany@mycompany.com', companywebsite: 'https://mautic.com/'});

It actually doesn't do anything. It won't create new company. The information will be lost. So some users could be searching for an answer why. The answer is that they must provide companyname in there too. Then the company will be created with the email and website they provided.

[kuzmany]

@escopecz your code create company with companyname mycompany
I am going to check again

[escopecz]

Nope, it did not create mycompany company because it check DNS MX record. But that's not the point. If you send in the page hit request companyaddress alone Mautic will ignore it. It must contain company or companyname to store the rest of the company* values. That I think should be documented.

[kuzmany]

@escopecz docs update mautic/documentation#266