Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

M3: Refactor Deprecations - NotificationBundle #8002

Closed
19 tasks done
alanhartless opened this issue Oct 26, 2019 · 1 comment
Closed
19 tasks done

M3: Refactor Deprecations - NotificationBundle #8002

alanhartless opened this issue Oct 26, 2019 · 1 comment
Assignees
@Enc3phale
Labels
ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged
Projects
Mautic 3
Milestone
3.0.0-beta

Comments

@alanhartless
Copy link
Contributor

alanhartless commented Oct 26, 2019 •
edited by npracht

NotificationBundle/Form/Type/MobileNotificationSendType.php

  • Nr. 251 line 100: Using deprecated interface Symfony\Component\OptionsResolver\OptionsResolverInterface
  • Nr. 252 line 100: Overriding deprecated method Mautic\NotificationBundle\Form\Type\MobileNotificationSendType->setDefaultOptions()
  • Nr. 253 line 108: Overriding deprecated method Mautic\NotificationBundle\Form\Type\MobileNotificationSendType->getName()

NotificationBundle/Form/Type/NotificationListType.php

  • Nr. 254 line 64: Overriding deprecated method Mautic\NotificationBundle\Form\Type\NotificationListType->getName()

NotificationBundle/Form/Type/MobileNotificationType.php

  • Nr. 255 line 209: Using deprecated interface Symfony\Component\OptionsResolver\OptionsResolverInterface
  • Nr. 256 line 209: Overriding deprecated method Mautic\NotificationBundle\Form\Type\MobileNotificationType->setDefaultOptions()
  • Nr. 257 line 223: Overriding deprecated method Mautic\NotificationBundle\Form\Type\MobileNotificationType->getName()

NotificationBundle/Form/Type/NotificationType.php

  • Nr. 258 line 211: Using deprecated interface Symfony\Component\OptionsResolver\OptionsResolverInterface
  • Nr. 259 line 211: Overriding deprecated method Mautic\NotificationBundle\Form\Type\NotificationType->setDefaultOptions()
  • Nr. 260 line 225: Overriding deprecated method Mautic\NotificationBundle\Form\Type\NotificationType->getName()

NotificationBundle/Form/Type/ConfigType.php

  • Nr. 261 line 152: Overriding deprecated method Mautic\NotificationBundle\Form\Type\ConfigType->getName()

NotificationBundle/Form/Type/MobileNotificationListType.php

  • Nr. 262 line 64: Overriding deprecated method Mautic\NotificationBundle\Form\Type\MobileNotificationListType->getName()

NotificationBundle/Form/Type/MobileNotificationDetailsType.php

  • Nr. 263 line 277: Overriding deprecated method Mautic\NotificationBundle\Form\Type\MobileNotificationDetailsType->getName()

NotificationBundle/Form/Type/NotificationSendType.php

  • Nr. 264 line 100: Using deprecated interface Symfony\Component\OptionsResolver\OptionsResolverInterface
  • Nr. 265 line 100: Overriding deprecated method Mautic\NotificationBundle\Form\Type\NotificationSendType->setDefaultOptions()
  • Nr. 266 line 108: Overriding deprecated method Mautic\NotificationBundle\Form\Type\NotificationSendType->getName()
@alanhartless alanhartless added this to the 3.0.0 milestone Oct 26, 2019
@alanhartless alanhartless added this to To do in Mautic 3 Nov 1, 2019
@Enc3phale Enc3phale moved this from To do to In progress in Mautic 3 Nov 1, 2019
@Enc3phale Enc3phale self-assigned this Nov 1, 2019
@Enc3phale Enc3phale moved this from In progress to Pending Feedback in Mautic 3 Nov 4, 2019
@Enc3phale Enc3phale added code-review-needed PR's that require a code review before merging pending-feedback PR's and issues that are awaiting feedback from the author labels Nov 4, 2019
@Enc3phale Enc3phale mentioned this issue Nov 4, 2019
Merged
@npracht npracht added ready-to-test PR's that are ready to test and removed pending-feedback PR's and issues that are awaiting feedback from the author labels Nov 4, 2019
@npracht npracht moved this from Pending Feedback to Needs user tests in Mautic 3 Nov 4, 2019
@escopecz escopecz added the pending-feedback PR's and issues that are awaiting feedback from the author label Nov 5, 2019
@escopecz escopecz moved this from Needs user tests to Pending Feedback in Mautic 3 Nov 5, 2019
@hluchas
Copy link
Contributor

hluchas commented Nov 14, 2019 •
edited

I was little bit lost
PR link: #8091

TY!

@escopecz escopecz added essential This must be done to close the milestone and removed pending-feedback PR's and issues that are awaiting feedback from the author labels Dec 6, 2019
@escopecz escopecz moved this from Pending Feedback to Needs code review and/or test in Mautic 3 Dec 9, 2019
@escopecz escopecz added ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged and removed code-review-needed PR's that require a code review before merging essential This must be done to close the milestone ready-to-test PR's that are ready to test labels Dec 9, 2019
@escopecz escopecz closed this as completed Dec 9, 2019
Mautic 3 automation moved this from Needs code review and/or test to Done Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Enc3phale Enc3phale

Labels
ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged
Projects
No open projects
Mautic 3
  
Done
Milestone
3.0.0-beta
Development

No branches or pull requests
5 participants
@alanhartless @escopecz @hluchas @npracht @Enc3phale