Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notification bundle deprecation refactoring #8091

Merged
merged 5 commits into from Dec 9, 2019
Merged

Notification bundle deprecation refactoring #8091

merged 5 commits into from Dec 9, 2019

Conversation

Enc3phale
Copy link
Contributor

@Enc3phale Enc3phale commented Nov 4, 2019 •
edited

Please be sure you are submitting this against the staging branch.

Q A
Bug fix? N
New feature? Y
Automated tests included? N
Related user documentation PR URL N
Related developer documentation PR URL N
Issues addressed (#s or URLs) #8002
BC breaks? N
Deprecations? N

Description:

This PR upgrades NotificationBundle Symfony Form types to work with Symfony 3.

Steps to test this PR:

  1. Load up this PR
  2. Test web notification and mobile notification

@Enc3phale Enc3phale added this to the 3.0.0 milestone Nov 4, 2019
@Enc3phale Enc3phale added Mautic 3 code-review-needed PR's that require a code review before merging ready-to-test PR's that are ready to test labels Nov 4, 2019
@escopecz
Copy link
Sponsor Member

escopecz commented Nov 5, 2019

@Enc3phale check Travis, please.

@hluchas hluchas mentioned this pull request Nov 14, 2019
Closed
19 tasks
@escopecz
Copy link
Sponsor Member

escopecz commented Dec 6, 2019

@Enc3phale could you also resolve the conflicts?

@escopecz escopecz self-assigned this Dec 9, 2019
escopecz
escopecz approved these changes Dec 9, 2019
View reviewed changes
Copy link
Sponsor Member

@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any problem in the code and all notification forms I could find work properly. Thanks! 👍

@escopecz escopecz removed code-review-needed PR's that require a code review before merging ready-to-test PR's that are ready to test labels Dec 9, 2019
@escopecz escopecz merged commit 5644e18 into mautic:m2-to-m3 Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@escopecz escopecz escopecz approved these changes

Assignees

@escopecz escopecz

Labels
None yet
Projects
None yet
Milestone
3.0.0-beta
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Enc3phale @escopecz