Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor use of MailHelper out of MauticFactory #8060

Closed
escopecz opened this issue Nov 1, 2019 · 4 comments
Closed

Refactor use of MailHelper out of MauticFactory #8060

escopecz opened this issue Nov 1, 2019 · 4 comments
Labels
enhancement Any improvement to an existing feature or functionality T3 Hard difficulty to fix (issue) or test (PR)
Milestone
4.0.0-alpha1

Comments

@escopecz
Copy link
Sponsor Member

escopecz commented Nov 1, 2019

MailHelper::validateEmail() is deprecated. Use EmailValidator service instead. Then remove the deprecated method.

mautic/plugins/MauticCrmBundle/Api/HubspotApi.php

Line 65 in 916cb75

MailHelper::validateEmail($email);

@escopecz escopecz added this to To do in Mautic 3 Nov 1, 2019
@ondrejsibl ondrejsibl self-assigned this Nov 21, 2019
@ondrejsibl ondrejsibl moved this from To do to In progress in Mautic 3 Nov 21, 2019
@ondrejsibl
Copy link
Contributor

This issue is more complexed. We can't inject EmailValidator service easily, because the class HubspotApi is created in 

mautic/plugins/MauticCrmBundle/Integration/CrmAbstractIntegration.php

Line 184 in 916cb75

$class = '\\MauticPlugin\\MauticCrmBundle\\Api\\'.$this->getName().'Api';

@ondrejsibl ondrejsibl moved this from In progress to To do in Mautic 3 Nov 26, 2019
@ondrejsibl ondrejsibl removed their assignment Nov 26, 2019
@escopecz escopecz moved this from To do to Has dependencies in Mautic 3 Nov 28, 2019
@escopecz escopecz changed the title Refactor use of MailHelper::validateEmail() in HubspotApi Refactor use of MailHelper out of MauticFactory Dec 6, 2019
@escopecz escopecz mentioned this issue Dec 6, 2019
Merged
@escopecz escopecz moved this from Has dependencies to To do in Mautic 3 Dec 9, 2019
@npracht npracht added this to the 3.0.0 milestone Jan 6, 2020
@alanhartless alanhartless modified the milestones: 3.0.0, 3.x Jan 28, 2020
@p365labs
Copy link
Contributor

p365labs commented Feb 19, 2020 •
edited

@ondrejsibl I'm not getting the point why we are validating the email and them send to HUBSPOT and they will validate it again...

cc @alanhartless @escopecz

@alanhartless alanhartless removed this from To do in Mautic 3 Mar 5, 2020
@p365labs
Copy link
Contributor

p365labs commented Mar 8, 2020

@alanhartless & @escopecz I've a PR for this if u want to have a look I can open it. wdyt?

@p365labs p365labs mentioned this issue Mar 8, 2020
Closed
@escopecz escopecz added this to To do in Mautic 3 via automation Mar 9, 2020
@escopecz escopecz moved this from To do to Pending Feedback in Mautic 3 Mar 9, 2020
@alanhartless
Copy link
Contributor

@p365labs Definitely PR something once ready! Or if you'd like us to review it before hand, just ensure that WIP is in the title. Thanks!

@alanhartless alanhartless removed this from Pending Feedback in Mautic 3 Mar 19, 2020
@RCheesley RCheesley added enhancement Any improvement to an existing feature or functionality T3 Hard difficulty to fix (issue) or test (PR) labels Jul 7, 2020
@RCheesley RCheesley modified the milestones: 3.x, Mautic 4.0 Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Any improvement to an existing feature or functionality T3 Hard difficulty to fix (issue) or test (PR)
Projects
None yet
Milestone
4.0.0-alpha1
Development

No branches or pull requests
6 participants
@alanhartless @p365labs @escopecz @RCheesley @ondrejsibl @npracht