EmailBundle - removing deprecated code

[escopecz]

Please be sure you are submitting this against the staging branch.

Q	A
Bug fix?
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs)	#7998
BC breaks?
Deprecations?

Description:

Steps to test this PR:

1. Load up this PR
2. Test all forms related to emails.
3. Including email related actions in campaign, form and point actions.

List deprecations along with the new alternative:

In https://docs.google.com/document/d/1lHNK8hHQtvyWlz9OtfAoLupDVb5-QunQjq-HAGlAsS4/edit#

List backwards compatibility breaks:

In https://docs.google.com/document/d/1lHNK8hHQtvyWlz9OtfAoLupDVb5-QunQjq-HAGlAsS4/edit#

[florentpetitjean]

Hello,

I've tested the followings :

• Create an email
• Clone an email
• Delete an email
• Open builder
• Change theme

All is working :)

[dongilbert]

Some conflicts need resolving

[escopecz]

Shouldn't we flip keys and values for ChoiceType type and use 'choices_as_values' option? (actually you showed me this)

Yes, it should. I must have forgot that step here. Thanks for noticing. Ready for second round.

[anton-vlasenko]

\Mautic\EmailBundle\Form\Type\EmailType
Could you please change form type to FQCN on lines 505 and 506 (hidden type)?

[escopecz]

@anton-vlasenko thanks! Fixed.

[anton-vlasenko]

The code seems to be fine.
But when I opened an "email view" page (it was a transactional email) and clicked on the "Add A/B test" dropdown option I got the following error:

[anton-vlasenko]

I'm sorry that I don't post all my findings in one post, but I keep finding items that have to be refactored (in my opinion).

1. A call to setMauticFactory method still present in the \Mautic\EmailBundle\Controller\AjaxController (lines 228, 229)
2. \Mautic\EmailBundle\Controller\EmailController extends Mautic\CoreBundle\Controller\FormController. FormController is deprecated. EmailController is also using $this->factory, which is also deprecated (MauticFactory).
3. \Mautic\EmailBundle\Controller\PublicController extends Mautic\CoreBundle\Controller\FormController. FormController is deprecated. PublicController is also using $this->factory, which is also deprecated (MauticFactory).
4. \Mautic\EmailBundle\Helper\MailHelper still uses MauticFactory ($this->factory).
5. \Mautic\EmailBundle\Swiftmailer\Transport\AbstractTokenArrayTransport still uses MauticFactory. It also has setMauticFactory method defined, which is deprecated.
6. \Mautic\EmailBundle\Swiftmailer\Transport\InterfaceTokenTransport is deprecated and should be removed.
7. \Mautic\EmailBundle\EmailEvents::ON_CAMPAIGN_TRIGGER_ACTION is deprecated and should be removed.
8. \Mautic\EmailBundle\Swiftmailer\Transport\AbstractTokenArrayTransport::$factory is deprecated (MauticFactory).
9. \Mautic\EmailBundle\Swiftmailer\Transport\AbstractTokenArrayTransport::setMauticFactory is deprecated.
10. \Mautic\EmailBundle\Swiftmailer\Transport\MandrillTransport on lines 253 and 289 it says that the BC support @deprecated. I think this has to be refactored.

[escopecz]

I will check the VariantType once my laptop is fixed.

We are not dealing with controllers in M3 and there is another issue to refactor the transports so those won't be refactored in this PR.

[anton-vlasenko]

there is another issue to refactor the transports so those won't be refactored in this PR.

@escopecz Thank you for explaining to me. I haven't noticed these issues on the board.

I just don't understand how the controllers are going to work if we don't refactor them. But If you say that they should not be refactored now I'm fine with that. I'm just curious what our plan is.
2. I'd like to ask what to do with the \Mautic\EmailBundle\EmailEvents::ON_CAMPAIGN_TRIGGER_ACTION. It's deprecated and it's not in the controller and/or transport.

[escopecz]

@anton-vlasenko I fixed the VariantType and created issue for the campaign batch deprecation #8191

[anton-vlasenko]

\Mautic\EmailBundle\Helper\MailHelper still uses MauticFactory.
It's not a controller/transport.
IMO we either have to refactor it in this PR or create an issue for it (I can't find it on the board).

[escopecz]

@anton-vlasenko here is the issue: #8060

Just to be clear what the current goal is. Let's make Mautic work on Symfony 3.4. If there will be time to refactor more we can do that. Removing MauticFactory is secondary goal. Let's focus on the primary goal.

[anton-vlasenko]

I don't know how I missed the issue.
The code looks fine.
I've tested it and didn't find any errors.
So I approve this PR.

[anton-vlasenko]

@escopecz Could you please merge it?