Code mode block vanish in the landing page builder

[florentpetitjean]

Bug Description

When adding a code mode block in the landing page builder, it can vanish if you don't let any "text" but let markup code in it.
the block is still there (visible in the browser console) but it no displaying anymore in the builder so it's hard to find it or move it again.

Q	A
Mautic version	2.16.0
PHP version
Browser	Chrome

Steps to reproduce

1. Create a new landing page

2. Go in the builder

3. Add a "code mode block"
   

4. remove the place holder text in the block but let the markup in the block
   

5. See that the block "vanish" in your page.

Log errors

[kuzmany]

But this PR should fixed it, doesn't it?

#6810

PS: I think that PR resolve just email builder, not landing page builder. Right? Can you confirm my consideration

[florentpetitjean]

I think you're right, don't have this bug in Email builder so the PR have fixed email but not landing page.

[kuzmany]

@florentpetitjean
I did test on landing page and placeholder works for me. Can you re-test?

[florentpetitjean]

I got the bug when I left code markup in the field, (like

or

) with the field totally empty it works like in your screenshot.

[kuzmany]

Let's test: #8340

Don't forget call php app/console mautic:assets:generate
And refresh cache in browser

[npracht]

Still not working !

[RCheesley]

Let's get this tested and merged in 3.1 - needs to be tested by 14th August.

@florentpetitjean can you take a look at the #8340 PR and give it a test?

[florentpetitjean]

Yes already review this PR, and working on production for us for a while.

[RCheesley]

Great, but your earlier review was before Mautic 3.x and rebasing which dismisses all previous reviews - can you just do a quick follow up test on M3 and report that on the PR?

[mautibot]

This issue has been mentioned on Mautic Community Forums. There might be relevant details there:

https://forum.mautic.org/t/mautic-3-1-new-beginnings/15787/1