Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Email theme upload is expecting email.html.twig but this is not present in MJML themes #9676

Closed
RCheesley opened this issue Feb 15, 2021 · 5 comments
Closed

Email theme upload is expecting email.html.twig but this is not present in MJML themes #9676

RCheesley opened this issue Feb 15, 2021 · 5 comments
Assignees
@kuzmany
Labels
bug Issues or PR's relating to bugs builder-grapesjs Anything related to the GrapesJS email or landing page builders T1 Low difficulty to fix (issue) or test (PR)

Comments

@RCheesley
Copy link
Sponsor Member

RCheesley commented Feb 15, 2021 •
edited

Bug Description

When trying to install a new MJML theme with the upload option in the Theme section we get the following error:

The theme you tried to install is missing the following required files and thus could not be installed: html/email.html.twig

An MJML theme will include an email.mjml.twig file rather than email.html.twig. We should probably add a check that looks for either?

Q A
Mautic version 3.3 Release Candidate
PHP version 7.4
Browser Chrome

Steps to reproduce

  1. Try to install an MJML Theme eg this blank theme
  2. Notice the issue when you try to upload it via the Themes UI
@RCheesley RCheesley added T1 Low difficulty to fix (issue) or test (PR) bug Issues or PR's relating to bugs builder-legacy Anything related to the legacy email or landing page builders labels Feb 15, 2021
@luizeof
Copy link
Member

luizeof commented Feb 23, 2021 •
edited

I can't send an MJML theme in 3.2.5 and the problem persists in 3.3.0

@kuzmany kuzmany self-assigned this Apr 23, 2021
@kuzmany kuzmany mentioned this issue Apr 24, 2021
Merged
@kuzmany
Copy link
Member

kuzmany commented Apr 24, 2021

I fixed it by this PR mautic/plugin-grapesjs-builder#74

@RCheesley RCheesley added builder-grapesjs Anything related to the GrapesJS email or landing page builders and removed builder-legacy Anything related to the legacy email or landing page builders labels Jun 29, 2021
@RCheesley
Copy link
Sponsor Member Author

Closing this issue as the fixing PR has been merged.

@andres-asm
Copy link

Weird, we're on 4.0 and we are still seeing this problem...

@kuzmany
Copy link
Member

kuzmany commented Oct 14, 2021

@fr500 in Mautic 4 you have to put MJML template to email.html.twig.

email.mjml.twig is not supported anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kuzmany kuzmany

Labels
bug Issues or PR's relating to bugs builder-grapesjs Anything related to the GrapesJS email or landing page builders T1 Low difficulty to fix (issue) or test (PR)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@luizeof @kuzmany @andres-asm @RCheesley