-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support mjml in email.html.twig #74
Add support mjml in email.html.twig #74
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed by testing with the theme provided and renaming the MJML file to HTML allowed me to upload the theme, and when I work with the template in the GrapesJS builder I am seeing the MJML markup when I click to view the code mode.
Seems does not work on edit, even If MJML was stored. I will check it |
@RCheesley without this PR there is a bug with MJML at current version? If create mjml email, then save & close, then try open builder - open HTML version of editor for me? Can you test it? |
@kuzmany yes I can reproduce that - as soon as I close the builder, without saving the email, it is in HTML - https://youtu.be/yKyTn4qqObI |
@adiux I suppose issue coming from this condition
Should be something
How it works on dev mode? I need run |
@RCheesley @adiux this should fixed it #76. Can you test also this PR? |
@kuzmany when I try to upload this file, with this PR applied, I am still getting the error:
What is this PR supposed to be addressing? The goal is that folk can upload a theme that is just MJML I think (eg email.mjml.twig), but maybe I am missing something here - did you change it so that the file can be email.html.twig but still contain only MJML? Would really appreciate some clarity on this both for testing the PR but also for the docs that @jos0405 is working on. |
@RCheesley I uploaded wrong theme Now MJML code is paste directly in email.html.twig - this is my change. |
Awesome - works great with that installer for the theme - was able to create the theme, and MJML markup is retained after saving also. There is still the issue with the device preview but will raise that as a separate issue. |
This pull request has been mentioned on Mautic Community Forums. There might be relevant details there: https://forum.mautic.org/t/theme-missing-email-html-twig/20665/1 |
This should fix this mautic/mautic#9676
At the moment If you want use MJML you need add to your template email.mjml.twig.
After this PR your template should have email.html.twig with MJML. This allow upload template without issue.
State before I marked as deprecated, we should rename email.mjml.twig to email.html.twig and note it to documentation.
Steps to tests:
Delete brienz theme and upload modified them with renamed email.mjml.twig to email.html.twig
brienz.zip
Try If template works like before