Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix doctrine fixtures double loading #10040

Closed
wants to merge 6 commits into from
Closed

Fix doctrine fixtures double loading #10040

wants to merge 6 commits into from

Conversation

shinde-rahul
Copy link
Contributor

@shinde-rahul shinde-rahul commented May 16, 2021 •
edited

Q A
Branch? "features" for all features, enhancements and bug fixes (until 3.3.0 is released)
Bug fix? yes
New feature? no
Deprecations? no
BC breaks? yes/no
Automated tests included? yes/no
Related user documentation PR URL mautic/mautic-documentation#...
Related developer documentation PR URL mautic/developer-documentation#...
Issue(s) addressed Fixes #10028

Description:

Steps to test this PR:

  1. Load up this PR
  2. Run bin/console d:f:l

@cla-bot cla-bot bot added the cla-signed The PR contributors have signed the contributors agreement label May 16, 2021
RCheesley
RCheesley previously approved these changes May 16, 2021
View reviewed changes
Copy link
Sponsor Member

@RCheesley RCheesley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the PR @shinde-rahul - this fixes the issue and there is no longer any duplication.

Are the files that you have removed in this PR no longer used? I wasn't sure if maybe the fake report data was being used to inject info into the reports.

@shinde-rahul
Copy link
Contributor Author

@RCheesley, the removed files were having duplicate code. As the InstallBundle has all required fixtures so removed those.

@RCheesley RCheesley added bug Issues or PR's relating to bugs installation Anything related to the installation of Mautic T1 Low difficulty to fix (issue) or test (PR) labels May 21, 2021
@RCheesley RCheesley added this to the 4.0-rc milestone May 21, 2021
@RCheesley RCheesley added code-review-needed PR's that require a code review before merging pending-test-confirmation PR's that require one test before they can be merged labels May 21, 2021
@RCheesley RCheesley requested a review from a team May 25, 2021 10:37
@RCheesley RCheesley modified the milestones: 4.0-rc, 4.0-ga Jun 28, 2021
@RCheesley
Copy link
Sponsor Member

Bumping from the release due to lack of testing/code review

@RCheesley RCheesley removed this from the 4.0-ga milestone Aug 23, 2021
@RCheesley RCheesley changed the base branch from features to 4.0 September 7, 2021 13:27
@stale
Copy link

stale bot commented Dec 6, 2021

This issue or PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you would like to keep it open please let us know by replying and confirming that this is still relevant to the latest version of Mautic and we will try to get to it as soon as we can. Thank you for your contributions.

@stale stale bot added the stale Issues which have not received an update within 90 days label Dec 6, 2021
@stale
Copy link

stale bot commented Dec 21, 2021

This issue or PR has been automatically closed because it has not had recent activity. In the case of issues, if it persists in the latest version of Mautic, please create a new issue and link back to this one for reference. With PRs if you wish to pick up the PR and update it so that it can be considered for a future release, please comment and we will re-open it. Thank you for your contributions.

@stale stale bot closed this Dec 21, 2021
@escopecz escopecz self-assigned this Oct 3, 2022
@escopecz escopecz mentioned this pull request Oct 3, 2022
Merged
@escopecz
Copy link
Sponsor Member

escopecz commented Oct 3, 2022

I couldn't cherry-pick this as the repo and the commits do not exist anywhere. So I made all the changes again in #11536

escopecz added a commit to escopecz/mautic that referenced this pull request Oct 17, 2022
@escopecz
Fix doctrine fixtures double loading by Rahul Shinde
4729924 
This is copy of changes from mautic#10040 which couldn't be cherry-picked as the repo was deleted
escopecz added a commit that referenced this pull request Oct 17, 2022
@escopecz
Fix doctrine fixtures double loading by Rahul Shinde (#11536)
785e1b5 
This is copy of changes from #10040 which couldn't be cherry-picked as the repo was deleted
mautibot pushed a commit to mautic/core-lib that referenced this pull request Oct 17, 2022
@escopecz
Fix doctrine fixtures double loading by Rahul Shinde (#11536)
4dda546 
This is copy of changes from mautic/mautic#10040 which couldn't be cherry-picked as the repo was deleted
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RCheesley RCheesley RCheesley approved these changes

Assignees

@escopecz escopecz

Labels
bug Issues or PR's relating to bugs cla-signed The PR contributors have signed the contributors agreement code-review-needed PR's that require a code review before merging installation Anything related to the installation of Mautic pending-test-confirmation PR's that require one test before they can be merged stale Issues which have not received an update within 90 days T1 Low difficulty to fix (issue) or test (PR)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Doctrine fixtures are double-loading reports and custom fields
3 participants
@shinde-rahul @RCheesley @escopecz