Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As can be seen in https://github.com/mautic/mautic/runs/2935394374?check_suite_focus=true, the OAuth1 removal PR breaks the update from an earlier Mautic version to M4 RC.
My assumption is that the code, during the update, still expects the
willdurand/oauth-server-bundle
dependency to be present (Symfony's container/cache maybe?), even though the consuming OAuth1 code has been removed in said PR.My suggested approach is to re-add the dependency, while this won't have any end-user impact as the OAuth1 functionality will still be absent in Mautic itself. Then, in e.g. 4.0.1 or 4.1.0, we can safely remove the dependency and make sure that that version requires at least Mautic 4.0.0 as the minimum installed version, since 4.0.0 will then remove the consuming OAuth1 code.
Easiest way to test is by checking out this PR, generating a release package with
php build/package_release.php -b oauth1-quickfix
, then with a Mautic 3 instance, apply the update package withbin/console mautic:update:apply --update-package=4.0.0-beta-update.zip
. Or, even simpler: merge this PR "as-is" and kick off the release process 😉Fixes #10195